services/horizon: Add ingestion processors run duration metrics #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
approved these changes
Nov 16, 2020
marcelosalloum
added a commit
that referenced
this pull request
Nov 18, 2020
…into recoverysigner-cap33 * 'recoverysigner-cap33' of https://github.com/stellar/go: services/horizon: Add ingestion processors run duration metrics (#3224)
This was referenced Nov 23, 2020
bartekn
added a commit
that referenced
this pull request
Nov 24, 2020
Improve performance of `OffersProcessor` by batching offers removals. Processor durations stats added in #3224 revealed that `OffersProcessor` is much slower than other processors. The reason is that offers are removed one-by-one what adds a total run time because of DB round-trip connection time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Add ingestion processors run duration metrics to better understand performance bottlenecks. The new metrics are exposed in
/metricsand summarize time spent in each ingestion processor.Known limitations
Some
ProcessorRunnermethods return 5 values now. Maybe we should change it to stuct?