Offer Created, Offer Updated, Offer Removed effects

[orbitlens]

Effects Offer Created, Offer Updated, Offer Removed are described in API docs, but they are not generated by the Horizon. Are there any specific reasons behind such behavior?

Those effects would be especially handy in case of historical asset price and orderbook recreation. I'm going to use historical data to implement coinmarketcap-like asset rating and trade volume history in my asset-centric block explorer. Besides, it's the only missing thing for the "time travel" feature, which will allow to view full asset/account stats for any point in timet.

Recreating active offers disposition at the particular point of time is really chalenging task without those effects implemented. Of course, I can parse raw XDR responses. However, I failed to found any solution for parsing XDR in SQL, so creating materialized view optimized for queries is not an option. On the other hand, parsing XDR outside the DB will result in additional tricky data sync with potentially stale data.

I understand that adding those effects may somewhat degrade the performance and increase Horizon DB size. So I would be very grateful if you could at least implement it as an optional feature that can be turned on by the env variable.

Thanks

[bartekn]

Confirmed. Looks like a bug in

go/services/horizon/internal/ingest/session.go

Line 479 in f08bdb8

func (is *Session) ingestTradeEffects(effects *EffectIngestion, buyer xdr.AccountId, claims []xdr.ClaimOfferAtom) {

It only processed trades.

[dmichael]

Is there an ETA for getting this scheduled for development?

The only workaround I know for getting offerId from an offer transaction (absolutely critical for trading applications) is to walk the XDR returned from the transaction (which is a little tedious).

I can write up how to get this id using the JS SDK, but don't have enough experience with Horizon yet to submit a PR here.

[tomerweller]

This is important for professional trading desks that are looking for an audit trail

[nullstyle]

This is important for professional trading desks that are looking for an audit trail

I would not use the effects table for an audit trail! Use the stellar-core history archives.

[tomquisel]

@bartekn @howardtw do you think we should make this an option since it may have performance impacts? Or avoid the complexity?