Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: Deprecate default base fee #1221

Closed
ire-and-curses opened this issue May 1, 2019 · 1 comment
Closed

txnbuild: Deprecate default base fee #1221

ire-and-curses opened this issue May 1, 2019 · 1 comment
Labels
txnbuild 2nd-generation transaction build library for Go SDK

Comments

@ire-and-curses
Copy link
Member

ire-and-curses commented May 1, 2019 •
edited
Loading

txnbuild uses a default base fee of 100 stroops. As discussed in #166, it should become mandatory to provide one.

If it's not done soon, this will have to be a deprecation warning etc.

Would be great to add an example to the docs of how to get dynamic fee suggestions from the client when this is done.
@ire-and-curses ire-and-curses added the txnbuild 2nd-generation transaction build library for Go SDK label May 1, 2019
@poliha poliha mentioned this issue Jun 21, 2019
Merged
@poliha poliha added this to the horizonclient 1.3.0 milestone Jun 26, 2019
@poliha
Copy link
Contributor

poliha commented Jun 26, 2019

closed in #1443

@poliha poliha closed this as completed Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ire-and-curses @poliha