Offer effects are missing from transaction

[dmichael]

During some testing, I found that offer creation against Horizon on testnet does not return effects for "Order Created". It does however return effects for "Trade".

After some digging, I came across this bit of code which seems to implement the trade effect resource history.EffectTrade, but not the other effects that are defined like history. EffectOfferCreated. If this is correct, then I assume that "Offer Updated" and "Offer Removed" will also be empty for successful transactions.

It is not clear whether these effects are logged in the DB and just not exposed as a resource or if they have just not been implemented at all. The docs imply a user of Horizon should expect these effects, but they are missing from responses.

One major problem with these missing effects is that a client application cannot validate that the offers were created with a successful transaction (you must assume that it worked). Further, if you want to track the id produced from the offer so that you can manage the order later, there is no choice but to query all offers and guess which one resulted from the transaction (this is too ambiguous to be used with real trades).

Just to be clear, offers are being committed with a transaction.

Thanks!

[dmichael]

Looks like a duplicate of #166