Add in effects that weren't being returned by Horizon

[martinxsliu]

I was looking at the way Horizon returns effects and I noticed that there were some effects and fields that weren't being serialized properly and hence not getting returned in the API. This PR adds in the missing effects.

Changes:

• Adds AuthImmutable flag for the AccountFlagsUpdated effect.
• Adds InflationDestination for the AccountInflationDestinationUpdated effect.
• Adds the DataCreated, DataRemoved, and DataUpdated effects.

For reference I've been using

go/services/horizon/internal/ingest/session.go

Line 106 in 081dd9c

func (is *Session) ingestEffects() {

as the authoritative source of effects and their fields.

[martinxsliu]

This was also reported in #294

[martinxsliu]

In the course of doing this, I also found that the offer effects: EffectOfferCreated, EffectOfferRemoved, and EffectOfferUpdated are not being created in the ingestEffects method I linked above, as their docstring might suggest. Are these effects an artifact from earlier times and should no longer be used?

[nullstyle]

In addition to the one comment I made about keeping the API unchanged, please implement some tests for this PR.

It's looking good; Thanks!

[nullstyle]

This isn't a refactoring; It changes the API, please revert it.

If you'll notice, these effects don't have asset_issuer fields. By embedding the base.Asset you will be including that field.

[nullstyle]

In the course of doing this, I also found that the offer effects: EffectOfferCreated, EffectOfferRemoved, and EffectOfferUpdated are not being created in the ingestEffects method I linked above, as their docstring might suggest. Are these effects an artifact from earlier times and should no longer be used?

We just need to implement them... the constants were simply defined before we got around to adding the effects into ingestion.

[bartekn]

@martinxsliu would you mind adding support to offer related effects (so basically closing #166)?

[howardtw]

@martinxsliu do you mind rebasing the PR? I believe InflationDestination for the AccountInflationDestinationUpdated effect has been added. I also have a PR adding offer related effects.

[bartekn]

Closing due to age and ingestion system deprecation.