Release 2023 05 16.1.fa26250 #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error, take 100
* Run multiple operators from FSS * Refactor installation * Refactor chart isntallation * Add TODO * Review comments * Review comments * Add rollback doc * Fix deployment * Update fleetshard/README.md Co-authored-by: Ludovic Cleroux <[email protected]> * Fix typo * Ignore long tag version for operator deployment * Update fleetshard/pkg/central/operator/upgrade.go Co-authored-by: Marcin Owsiany <[email protected]> * Update fleetshard/pkg/runtime/runtime.go Co-authored-by: Marcin Owsiany <[email protected]> * Fail fast on parsing images * Add TODO to disable installing operator subscription * Extend rollback in README.md * Set TODOs for dropping acs operator template * Add re-terraform in case of rollback * Log namespace * Drop CRD check * Apply suggestions from code review Co-authored-by: Marcin Owsiany <[email protected]> * Review coments * Update fleetshard/pkg/central/operator/upgrade_test.go Co-authored-by: Ludovic Cleroux <[email protected]> * Update fleetshard/pkg/central/charts/data/rhacs-operator/templates/rhacs-operator-deployment.yaml Co-authored-by: Ludovic Cleroux <[email protected]> * Fix formatting * Add note about deleting OperatorGroup * Rename unique set for unique images * Update fleetshard/pkg/central/operator/upgrade.go Co-authored-by: Marcin Owsiany <[email protected]> * Rename deployment prefix and pass it completely --------- Co-authored-by: Ludovic Cleroux <[email protected]> Co-authored-by: Marcin Owsiany <[email protected]>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.248 to 1.44.255. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.248...v1.44.255) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.255 to 1.44.256. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.255...v1.44.256) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michaël <[email protected]>
* Refactor helm chart installation * Review comment
Nico and I are going to use acs-stage-eu-01 for Addon Package testing. To do so we need to make sure the Helm chart is removed from that cluster and will not be reinstalled there.
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.14.0 to 1.15.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.14.0...v1.15.1) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.9.2 to 2.9.4. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.9.2...v2.9.4) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1017) * Bump github.com/openshift-online/ocm-sdk-go from 0.1.331 to 0.1.339 Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.331 to 0.1.339. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.331...v0.1.339) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Drop deprecated Cluster dep --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Kurlov <[email protected]>
skip final snapshots for probe
This will enable us to set up a Slack receiver for alerts that we don't want going to PagerDuty. This configuration was pulled directly from the generated version of this secret in one of our data plane clusters and modified to be generated by this Helm chart instead. There is no functional difference between this config and the one generated by the Observability operator. The PagerDuty and Dead Man's Snitch secrets are deleted since those secrets are now used directly in the Alertmanager configuration.
Prometheus operator specifically looks for `alertmanager.yaml`, NOT `alertmanager.yml`. If it cannot find that specific key, it will use a default/dummy congiruation instead, effectively disabling alertmanager.
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.42.0 to 0.43.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.42.0...v0.43.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/operator-framework/api](https://github.com/operator-framework/api) from 0.17.4 to 0.17.5. - [Release notes](https://github.com/operator-framework/api/releases) - [Changelog](https://github.com/operator-framework/api/blob/master/RELEASE.md) - [Commits](operator-framework/api@v0.17.4...v0.17.5) --- updated-dependencies: - dependency-name: github.com/operator-framework/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.9.2 to 2.9.5. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.9.2...v2.9.5) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kurlov
approved these changes
May 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0x656b694d, kurlov, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kovayur
pushed a commit
that referenced
this pull request
Jan 17, 2024
## Description <!-- Please include a summary of the change and a link to the JIRA ticket. Please add any additional motivation and context as needed. Screenshots are also welcome --> Release ACSCS 2023-05-16.1.fa26250 ## Checklist (Definition of Done) <!-- Please strikethrough options not relevant using two tildes ~~Text~~. Do not delete non relevant options --> - [ ] Unit and integration tests added - [ ] Added test description under `Test manual` - [ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...) - [ ] CI and all relevant tests are passing - [ ] Add the ticket number to the PR title if available, i.e. `ROX-12345: ...` - [ ] Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel. - [ ] Add secret to app-interface Vault or Secrets Manager if necessary ## Test manual **TODO:** Add manual testing efforts ``` # To run tests locally run: make db/teardown db/setup db/migrate make ocm/setup OCM_OFFLINE_TOKEN=<ocm-offline-token> OCM_ENV=development make verify lint binary test test/integration ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release ACSCS 2023-05-16.1.fa26250
Checklist (Definition of Done)
Test manualROX-12345: ...Test manual
TODO: Add manual testing efforts