-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-15941: Run multiple operators from FSS #951
ROX-15941: Run multiple operators from FSS #951
Conversation
Skipping CI for Draft Pull Request. |
@@ -34,8 +34,6 @@ spec: | |||
value: quay.io/rhacs-eng | |||
- name: ROX_OPERATOR_COLLECTOR_REGISTRY | |||
value: quay.io/rhacs-eng | |||
- name: OPERATOR_CONDITION_NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this env was created by OLM and it is redundant for FSS
/test e2e |
# TODO: Split image into registry and image name + tag | ||
image: quay.io/rhacs-eng/stackrox-operator:3.74.0 | ||
# TODO: and values for resource limits and requests for both proxy and manager container | ||
deploymentPrefix: rhacs-operator-controller-manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we make this smaller? This way we could have many more characters available for the repository/version suffix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped -controller
part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, some nitpicks inline and +1 to those from @ludydoo
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov, porridge, SimonBaeumer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Co-authored-by: Marcin Owsiany <[email protected]>
/test e2e |
Description
Make FSS able to run multiple ACS Operator versions.
Each operator version has its own deployment.
The metrics service and ServiceAccount can be shared between multiple versions.
For the sake of simplicity, there are two versions installed on startup before reconciler run.
The next steps are:
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
First of all, the OLM based ACS Operator should be deleted without removing an existing CRDs
Then it's time to run and verify
4. Build and deploy