-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-13692: create final snapshot for tenant db #994
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any retention rules for the final snapshot?
@kovayur This is an excellent point. I thought it would use the same retention period as automated Snapshots. But turns out "Final Snapshots" are "Manual Snapshots" in AWS terms which don't have a retention mechanism like "System Snapshots". So this means if we do final snapshots, we have to make sure to clean them up at some point. What do you think about creating a scheduled GitHub Workflow to do this? |
aef98bb
to
68ea635
Compare
68ea635
to
bdcf920
Compare
This reverts commit 06e11f6.
Description
This PR changes the central tenant DB deletion for RDS so that it always creates a final snapshot this is required in order to restore the tenant in case it has been deleted accidentally by a customer, an engineer or an error in the code.
Checklist (Definition of Done)
Test manual
ROX-12345: ...
Test manual
Adding test case and running rds tests locally and in CI.