Upgrade go version to 1.20 #1005
Conversation
| @@ -330,11 +330,6 @@ test/rds: $(GOTESTSUM_BIN) | |||
| ./fleetshard/pkg/central/cloudprovider/awsclient/... | |||
| .PHONY: test/rds | |||
|
|
|||
| # Precompile everything required for development/test. | |||
| test/prepare: | |||
| $(GO) test -i ./internal/dinosaur/test/integration/... | |||
There was a problem hiding this comment.
The go build and go test commands no longer accept the -i flag, which has been deprecated since Go 1.16.
https://tip.golang.org/doc/go1.20
| @@ -56,6 +56,9 @@ func (m *DataMigration) migrateOrganisationNames() (int, error) { | |||
| glog.Infof("migrated column %q to new value %q for central instance %q ", colName, central.OrganisationName, central.ID) | |||
| migratedCnt++ | |||
| } | |||
| if err := rows.Err(); err != nil { | |||
There was a problem hiding this comment.
|
Where did you find the reference to registry.ci.openshift.org/stolostron/builder:go1.20-linux? |
@kylape there's no |
|
hmmm neither of those image seem to be intended for broad use -- I worry they would be removed unexpectedly. I admit, though, that I don't really have a great alternative after doing a bit of searching. I assume we need to use something on registry.ci.openshift.org? Or can we use something outside of that regsitry? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kovayur, kurlov, porridge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since we don't have any alternatives atm, let's merge this now and solve the problem if it has arisen. We could use images available from both openshift CI and app-interface (i.e. quay.io or registry.access.redhat.com). Ideally I'd use registry.access.redhat.com/ubi8/go-toolset image, but there's no golang 1.20 yet.. |
Description
Upgrade go version to 1.20.
Checklist (Definition of Done)
Unit and integration tests addedTest manualDocumentation added if necessary (i.e. changes to dev setup, test execution, ...)Add the ticket number to the PR title if available, i.e.ROX-12345: ...Add secret to app-interface Vault or Secrets Manager if necessaryTest manual
CI