Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all the integration tests (2020-05-07) #449

Merged
merged 1 commit into from
May 8, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 8, 2020

Summary

This pull request applies the changes detected by integration tests. The only change to model classes is:

  • Add author_id to attachment / Attachement#authorId: String

Other changes in JSON files are the results of JSON recorder bug fixes by #448

Requirements (place an x in each [ ])

@seratch seratch added the project:slack-api-model project:slack-api-model label May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #449 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
+ Coverage     83.99%   84.06%   +0.06%     
- Complexity     2385     2386       +1     
============================================
  Files           250      250              
  Lines          6406     6406              
  Branches        579      579              
============================================
+ Hits           5381     5385       +4     
+ Misses          667      663       -4     
  Partials        358      358              
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/com/slack/api/model/Attachment.java 100.00% <ø> (ø) 10.00 <0.00> (ø)
...pi/methods/metrics/impl/RedisMetricsDatastore.java 89.50% <0.00%> (+2.46%) 38.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3328be4...868baa8. Read the comment docs.

@seratch seratch merged commit 335cac2 into slackapi:master May 8, 2020
@seratch seratch added this to the 1.0.x milestone May 8, 2020
@seratch seratch deleted the run-tests-2020-05-07 branch May 8, 2020 01:45
seratch added a commit that referenced this pull request May 8, 2020
* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch
* [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink
* [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch
* [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos
* [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch
* [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch
* [slack-api-model] #449 Add attachement.author_id - thanks @seratch
* [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch
* [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch
* [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink
* [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch
* [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos
* [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch
* [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch
* [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch
* [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch
* [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:slack-api-model project:slack-api-model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant