Bump dependencies (okhttp 4.4 -> 4.6 etc) #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [slack-api-client] okhtp 4.4.1 to 4.6.0 * diff: square/okhttp@parent-4.4.1...parent-4.6.0 * changelog: v4.5.0 - https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-450 > This release fixes a severe bug where OkHttp incorrectly detected and recovered from unhealthy connections * changelog: v4.6.0 - https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-460 * [bolt-jetty] jetty-server 9.4.27 to 9.4.28 * [bolt-micronaut] micronaut 1.3.3 to 1.3.4 * [bolt] aws-java-sdk-s3 1.11.757 to 1.11.774
Codecov Report
@@ Coverage Diff @@
## master #444 +/- ##
=========================================
Coverage 84.04% 84.04%
Complexity 2371 2371
=========================================
Files 250 250
Lines 6376 6376
Branches 578 578
=========================================
Hits 5359 5359
Misses 661 661
Partials 356 356 Continue to review full report at Codecov.
|
stevengill
approved these changes
May 4, 2020
seratch
added a commit
that referenced
this pull request
May 8, 2020
* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] #449 Add attachement.author_id - thanks @seratch * [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch * [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request bumps patch/minor versions of the following dependencies.
I'd like to include okhttp's minor version upgrade as they're saying upgrading 4.5+ is highly recommended.
I've verified the behavior by running all the integration tests under
test_with_remote_apispackages and don't see any issues in the range of this library's usage.Regarding okhttp 4.x series, I've never encountered any binary incompatibility issues throughout the releases. I'm sure it's safe enough to upgrade their minor versions among our patch versions.
Requirements (place an
xin each[ ])