Update composition.OptionObject to have mrkdwn for some cases #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
=========================================
Coverage 83.88% 83.88%
Complexity 2367 2367
=========================================
Files 249 249
Lines 6366 6366
Branches 578 578
=========================================
Hits 5340 5340
Misses 672 672
Partials 354 354
Continue to review full report at Codecov.
|
seratch
added a commit
that referenced
this pull request
May 8, 2020
* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] #449 Add attachement.author_id - thanks @seratch * [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
emanguy
pushed a commit
to emanguy/java-slack-sdk
that referenced
this pull request
Jun 22, 2020
* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch * [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink * [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch * [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos * [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch * [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch * [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch * [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch * [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request changes the type of
option.textin Block elements to accept not onlyplain_textbutmrkdwnforradion_buttonsandcheckboxes. As theTextObjectis a super type ofPlainTextObject, this change is backward-compatible for both source and binary compatibility.Reference: https://api.slack.com/reference/block-kit/composition-objects#option
Requirements (place an
xin each[ ])