Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #445 by adding admin.usergroups.* API #448

Merged
merged 3 commits into from
May 8, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented May 7, 2020

Summary

This pull request fixes #445

Requirements (place an x in each [ ])

@seratch seratch added enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client labels May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #448 into master will increase coverage by 0.02%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #448      +/-   ##
============================================
+ Coverage     84.04%   84.07%   +0.02%     
- Complexity     2371     2387      +16     
============================================
  Files           250      250              
  Lines          6376     6406      +30     
  Branches        578      579       +1     
============================================
+ Hits           5359     5386      +27     
- Misses          661      663       +2     
- Partials        356      357       +1     
Impacted Files Coverage Δ Complexity Δ
...va/com/slack/api/methods/MethodsRateLimitTier.java 90.00% <0.00%> (-10.00%) 2.00 <1.00> (ø)
.../java/com/slack/api/methods/MethodsRateLimits.java 98.29% <ø> (ø) 8.00 <0.00> (ø)
...lack/api/methods/impl/AsyncMethodsRateLimiter.java 62.12% <0.00%> (-1.95%) 19.00 <0.00> (ø)
...java/com/slack/api/methods/RequestFormBuilder.java 93.64% <100.00%> (+0.08%) 228.00 <3.00> (+3.00)
...slack/api/methods/impl/AsyncMethodsClientImpl.java 98.32% <100.00%> (+0.03%) 284.00 <6.00> (+6.00)
.../com/slack/api/methods/impl/MethodsClientImpl.java 92.12% <100.00%> (+0.09%) 405.00 <6.00> (+6.00)
...i/methods/metrics/impl/MemoryMetricsDatastore.java 92.25% <0.00%> (+0.70%) 42.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab6588...1873880. Read the comment docs.

@seratch seratch merged commit 3328be4 into slackapi:master May 8, 2020
@seratch seratch deleted the issue-445 branch May 8, 2020 01:16
@seratch seratch added this to the 1.0.x milestone May 8, 2020
seratch added a commit that referenced this pull request May 8, 2020
* [slack-api-client] #444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch
* [slack-api-model] #441 #442 Fix Block Elements' object equality issues - thanks @eamelink
* [slack-api-client] #445 #448 Add admin.usergroups.* API supports - thanks @seratch
* [slack-api-model] #440 Add external data source supports for dialogs - thanks @favalos
* [slack-api-model] #437 Update composition.OptionObject to have mrkdwn - thanks @seratch
* [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch
* [slack-api-model] #449 Add attachement.author_id - thanks @seratch
* [slack-app-backend] #446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch
* [slack-api-client etc] #444 #450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
emanguy pushed a commit to emanguy/java-slack-sdk that referenced this pull request Jun 22, 2020
* [slack-api-client] slackapi#444 okhttp 4.4 -> 4.6 uprgrade (as it's highly recommended) - thanks @seratch
* [slack-api-model] slackapi#441 slackapi#442 Fix Block Elements' object equality issues - thanks @eamelink
* [slack-api-client] slackapi#445 slackapi#448 Add admin.usergroups.* API supports - thanks @seratch
* [slack-api-model] slackapi#440 Add external data source supports for dialogs - thanks @favalos
* [slack-api-model] slackapi#437 Update composition.OptionObject to have mrkdwn - thanks @seratch
* [slack-api-model] Add teams[].team_url to admin.teams.list response - thanks @seratch
* [slack-api-model] slackapi#449 Add attachement.author_id - thanks @seratch
* [slack-app-backend] slackapi#446 Add channel_count to subteam_created / subteam_updated events - thanks @seratch
* [slack-api-client etc] slackapi#444 slackapi#450 bump patch versions of AWS SDK, Micronaut, Jetty - thanks @seratch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:slack-api-client project:slack-api-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin.usergroups.* API
1 participant