Speed optimize test case pretty printing

[staabm]

because the colored printing is slow and most of the time its not used, see investigation in #5728 (comment)

github.com didn't let me re-open the previous PR, therefore I created a new one.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (e04999a) to head (76c826f).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #5735   +/-   ##
=========================================
  Coverage     90.01%   90.01%           
- Complexity     6491     6492    +1     
=========================================
  Files           688      688           
  Lines         19715    19720    +5     
=========================================
+ Hits          17746    17751    +5     
  Misses         1969     1969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[staabm]

new approach looks good - perf wise

[sebastianbergmann]

After this change, TestDox::prettifiedMethodName(true) will no longer return a colorized version of the prettified test method name when colorized output is not requested. This is confusing and not acceptable, sorry.

We should instead change the signature from prettifiedMethodName(bool $colorize = false) to prettifiedMethodName() to make it clear that the method can no longer optionally return a colorized string.

When colorized output in TestDox format is configured, we should perform the colorization in (invoke it from) PHPUnit\TextUI\Output\TestDox\ResultPrinter.

[staabm]

when TestDox is created via fromClassNameAndMethodName - even before this PR TestDox::prettifiedMethodName(true) will also not return colorized output

When colorized output in TestDox format is configured, we should perform the colorization in (invoke it from) PHPUnit\TextUI\Output\TestDox\ResultPrinter.

to colorize we need a reference to a TestCase, which we don't have in the ResultPrinter

[staabm]

after #5747 and #5748 landed, I need to re-measure whether this PR is still worth it

[staabm]

the pretty printing is still visible in the profiles.. but pretty minor now. in case we could drop doing it in non --testdox that would be awesome.

atm I don't see a way to achieve this though.