Drop colored prettified method name printing

sebastianbergmann · Mar 11, 2024 · 6b9462d · 6b9462d
1 parent 0bddfd3
commit 6b9462d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/src/Event/Value/Test/TestDox.php b/src/Event/Value/Test/TestDox.php
@@ -9,6 +9,8 @@
  */
 namespace PHPUnit\Event\Code;
 
+use RuntimeException;
+
 /**
  * @psalm-immutable
  *
@@ -18,24 +20,25 @@
 {
     private string $prettifiedClassName;
     private string $prettifiedMethodName;
-    private string $prettifiedAndColorizedMethodName;
 
-    public function __construct(string $prettifiedClassName, string $prettifiedMethodName, string $prettifiedAndColorizedMethodName)
+    public function __construct(string $prettifiedClassName, string $prettifiedMethodName)
     {
-        $this->prettifiedClassName              = $prettifiedClassName;
-        $this->prettifiedMethodName             = $prettifiedMethodName;
-        $this->prettifiedAndColorizedMethodName = $prettifiedAndColorizedMethodName;
+        $this->prettifiedClassName  = $prettifiedClassName;
+        $this->prettifiedMethodName = $prettifiedMethodName;
     }
 
     public function prettifiedClassName(): string
     {
         return $this->prettifiedClassName;
     }
 
+    /**
+     * @throws RuntimeException
+     */
     public function prettifiedMethodName(bool $colorize = false): string
     {
         if ($colorize) {
-            return $this->prettifiedAndColorizedMethodName;
+            throw new RuntimeException('Pretty printing method names is no longer supported for performance reasons.');
         }
 
         return $this->prettifiedMethodName;

diff --git a/src/Event/Value/Test/TestDoxBuilder.php b/src/Event/Value/Test/TestDoxBuilder.php
@@ -24,7 +24,6 @@ public static function fromTestCase(TestCase $testCase): TestDox
         return new TestDox(
             $prettifier->prettifyTestClassName($testCase::class),
             $prettifier->prettifyTestCase($testCase, false),
-            $prettifier->prettifyTestCase($testCase, true),
         );
     }
 
@@ -36,12 +35,9 @@ public static function fromClassNameAndMethodName(string $className, string $met
     {
         $prettifier = new NamePrettifier;
 
-        $prettifiedMethodName = $prettifier->prettifyTestMethodName($methodName);
-
         return new TestDox(
             $prettifier->prettifyTestClassName($className),
-            $prettifiedMethodName,
-            $prettifiedMethodName,
+            $prettifier->prettifyTestMethodName($methodName),
         );
     }
 }
diff --git a/src/TextUI/Output/TestDox/ResultPrinter.php b/src/TextUI/Output/TestDox/ResultPrinter.php
@@ -98,7 +98,7 @@ private function printTestResultHeader(TestDoxTestResult $test): void
             $this->printer->print($buffer);
         }
 
-        $this->printer->print($test->test()->testDox()->prettifiedMethodName($this->colors) . PHP_EOL);
+        $this->printer->print($test->test()->testDox()->prettifiedMethodName() . PHP_EOL);
     }
 
     private function printTestResultBody(TestDoxTestResult $test): void