Speed optimize test case pretty printing.

sebastianbergmann · Mar 12, 2024 · 76c826f · 76c826f
1 parent e04999a
commit 76c826f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/Event/Value/Test/TestDoxBuilder.php b/src/Event/Value/Test/TestDoxBuilder.php
@@ -17,14 +17,22 @@
  */
 final readonly class TestDoxBuilder
 {
-    public static function fromTestCase(TestCase $testCase): TestDox
+    public static function fromTestCase(TestCase $testCase, bool $colorize): TestDox
     {
         $prettifier = new NamePrettifier;
 
+        $prettyTestCase = $prettifier->prettifyTestCase($testCase, false);
+
+        if ($colorize) {
+            $prettyTestCaseColorized = $prettifier->prettifyTestCase($testCase, true);
+        } else {
+            $prettyTestCaseColorized = $prettyTestCase;
+        }
+
         return new TestDox(
             $prettifier->prettifyTestClassName($testCase::class),
-            $prettifier->prettifyTestCase($testCase, false),
-            $prettifier->prettifyTestCase($testCase, true),
+            $prettyTestCase,
+            $prettyTestCaseColorized,
         );
     }
 
@@ -34,8 +42,7 @@ public static function fromTestCase(TestCase $testCase): TestDox
      */
     public static function fromClassNameAndMethodName(string $className, string $methodName): TestDox
     {
-        $prettifier = new NamePrettifier;
-
+        $prettifier           = new NamePrettifier;
         $prettifiedMethodName = $prettifier->prettifyTestMethodName($methodName);
 
         return new TestDox(

diff --git a/src/Event/Value/Test/TestMethodBuilder.php b/src/Event/Value/Test/TestMethodBuilder.php
@@ -17,6 +17,7 @@
 use PHPUnit\Event\TestData\TestDataCollection;
 use PHPUnit\Framework\TestCase;
 use PHPUnit\Metadata\Parser\Registry as MetadataRegistry;
+use PHPUnit\TextUI\Configuration\Registry;
 use PHPUnit\Util\Reflection;
 use SebastianBergmann\Exporter\Exporter;
 
@@ -32,13 +33,14 @@ public static function fromTestCase(TestCase $testCase): TestMethod
         assert(!empty($methodName));
 
         $location = Reflection::sourceLocationFor($testCase::class, $methodName);
+        $colors   = Registry::get()->colors();
 
         return new TestMethod(
             $testCase::class,
             $methodName,
             $location['file'],
             $location['line'],
-            TestDoxBuilder::fromTestCase($testCase),
+            TestDoxBuilder::fromTestCase($testCase, $colors),
             MetadataRegistry::parser()->forClassAndMethod($testCase::class, $methodName),
             self::dataFor($testCase),
         );