Lazy collorize method name

[staabm]

looking into blackfire profiles I can see the TestDoc colorization takes 10-15% of runtime.

testing of this PR confirmed the thesis

before

php ./phpunit --testsuite unit     
…
Time: 00:00.466, Memory: 44.00 MB

after

php ./phpunit --testsuite unit     
…
Time: 00:00.420, Memory: 52.00 MB

blackfire diff

---

now the bad news :-). while this PR works with the unit test-suite, it does not with the end-to-end suite.

I can see that the changed TestDox class is no longer serializable, and therefore does not work with tests using process isolation or similar features.

since 10-15% percent is not that bad, I figured it would nevertheless make sense to bring this up for discussion.
maybe we can utilize the basic idea of doing coloring lazily for all tests which do not use process isolation..?

I would love anyones feedback

[sebastianbergmann]

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

PHPUnit\Event\Code\TestDox is a value object and must not do anything else than hold the values and provide access to it.

[staabm]

yeah I realized it, after everything broke when changing it :-).

the only place we currently - depending on config - use colorizing of the pretty method name is here:

phpunit/src/TextUI/Output/TestDox/ResultPrinter.php

Line 101 in 3b2a455

$this->printer->print($test->test()->testDox()->prettifiedMethodName($this->colors) . PHP_EOL);

what do you think about moving - the colorization part only - out of the TestDox class and move it instead in the only class which uses it?

[sebastianbergmann]

Makes sense, I think.

This would mean, though, that the optional $colorize parameter of TestDox::prettifiedMethodName(bool $colorize = false) would no longer have an effect as the value TestDox object would only have the prettified method name without colors. This would be a (very tiny) break of backward compatibility.

I am all for implementing this in the next major version. I am still pondering whether this break of backward compatibility could be considered negligible, allowing us to do it in the next patch release.

[staabm]

did some research on github.com and I was not able to find a single project which call TestDox->prettifiedMethodName(true) (except phpunit forks)