Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HOC Homepage Banner #981

Closed
mewtaylor opened this issue Oct 24, 2016 · 8 comments
Closed

Create HOC Homepage Banner #981

mewtaylor opened this issue Oct 24, 2016 · 8 comments

Comments

@mewtaylor
Copy link
Contributor

mewtaylor commented Oct 24, 2016

New banner at the top of the homepage that will be present for the two weeks around Hour of Code. This will contain links to the new T3 page, as well as specific resources to get started with (in the form of new tiles, as specified in #979).

Components to use:

@carljbowman
Copy link
Contributor

carljbowman commented Oct 25, 2016

Logged-in State

  • Includes 'Get Creative with Coding' Banner
  • Includes 'Design a Character' Event Row

Desktop - 12col

'Get Creative with Coding' Banner

  • 'See things to try' points to the Things to Try page (see Create "Things to Try" page #979)
  • Resource tiles (everything above dotted line) point to their associated Tutorial
  • 'See Cards and Guides' will open a modal with associated resources

'Design a Character' Event Row

r2 0_splash-logged-in

r2 0_splash-logged-in grid

Tablet to Desktop - 8col

'Get Creative with Coding' Banner

  • Tutorial tiles hidden
  • Center align and stack text / 'See things to try' button

'Design a Character' Event Row

  • Hidden

r2 0_splash-logged-in 8col

r2 0_splash-logged-in 8col-grid

Mobile to Tablet - 6col

'Get Creative with Coding' Banner

  • Tutorial tiles hidden
  • Center align and stack text / 'See things to try' button

'Design a Character' Event Row

  • Hidden

r2 0_splash-logged-in 6col

r2 0_splash-logged-in 6col-grid

Mobile - 4col

'Get Creative with Coding' Banner

  • Tutorial tiles hidden
  • Center align and stack text / 'See things to try' button

'Design a Character' Event Row

  • Hidden

r2 0_splash-logged-in 4col

r2 0_splash-logged-in 4col-gird


Non-logged-in State

  • Includes 'Get Creative with Coding' Banner

Desktop

  • Same behavior as 'Logged-in State'

r2 0_splash-logged-out

@jwzimmer-zz jwzimmer-zz self-assigned this Nov 22, 2016
mewtaylor added a commit that referenced this issue Nov 23, 2016
* feature/gh-981:
  Add hoc banner
  Move padding to splash element
  trello-ize title banner h1,p styling

# Conflicts:
#	src/components/title-banner/title-banner.scss
#	src/views/hoc/hoc.jsx
@jwzimmer-zz
Copy link
Contributor

jwzimmer-zz commented Nov 28, 2016

Testing

Design diffs
Chrome 54, Mac OS 10.11, Staging

  • The "see things to try" button has more padding in copy than on Staging
  • Font is slightly less bold/ more spaced-out kerning in copy than on Staging (I know this is probably unavoidable as per previous discussions with @carljbowman but just want to verify)
  • Things to try button right edge is not aligned with the right edge of the rightmost card, title not aligned with leftmost card --> HOC banner - Edges of tiles not aligned with banner title/ button #1076 (not a blocker)

Functionality
Chrome 54, Mac OS 10.11, Staging

  • The "see things to try" button redirects to the TTT /go page
  • Try It & sheer hover effects for each tile
  • Clicking anywhere on tile redirects to editor with Tips window open at appropriate content
  • See Cards & Guides opens modal
  • X to close modal
  • Click outside modal to close
  • Buttons in modal work
  • When logged in or out, the banner should not change
    • The navbar should change state as usual

Responsiveness

Localization
Firefox 50.0, Mac OS 10.11, Staging

  • Choose several different languages and make sure functionality remains
    • Bulgarian
      • Clicked around, everything looks ok (although not much is translated)
    • Catalan
      • Banner title is translated, 2 tile titles are translated
      • Clicking "Animate your name" tile opens editor + tips window, both in Catalan
        • Modal opens
        • Clicking outside modal closes it
        • Try it, Open buttons work as expected from modal
      • Hover effects still work
      • Link to a project from "What's Happening" Activity Feed works
    • Hebrew
      • No real change in RTL vs. LTR display

Other
Chrome 54, Mac OS 10.11, Staging

Compatibility
Edge 38.14393.0.0 on Windows 10

  • See things to try button goes to TTT page
  • 3 tiles, button, title all look reasonable
    • Post @mewtaylor's fix to the button location relative to the title location, they look more centered (although perhaps still not exactly centered as in the spec - discussed this with @mewtaylor and I think it's a non-issue, verified that with @carljbowman)
  • Fly cards pdf opens from the modal > Open button
  • Make Music modal can be closed with X
    • Or by clicking outside it

@carljbowman
Copy link
Contributor

@jwzimmer - Thanks for logging the diffs. Both are okay.

  • Re Button: Totally fine, for consistency on the site we are using the button component which dictates the padding. That being said at some point we should update the styling to have more padding and remove the drop-shadow.
  • Re Font: Certainly falls in the case where there is not much we can do about how fonts will be rendered across browsers. What is on staging looks fine to me.

@mewtaylor
Copy link
Contributor Author

Added in #1073

@chrisgarrity
Copy link
Contributor

chrisgarrity commented Nov 30, 2016

On Mobile checked with Nexus 5X (Android 7.0):

  • Portrait mode:
    • banner text is centered
    • See things to try link goes to /go (TTT page)
  • Landscape mode:
    • banner text is centered within view

    • but page scrolls sideways, and the banner does not fill the page width
      screenshot_20161130-094700

    • See things to try link goes to /go (TTT page)

  • Switching between portrait and landscape:
    • page does not scroll (fills view), but banner is off center
      screenshot_20161130-094634

@mewtaylor
Copy link
Contributor Author

@chrisgarrity cool thanks – looks like this is a splash page problem (see the news box), which probably merits its own issue. Unless we want to just say it'll be addressed in the homepage redesign?

@chrisgarrity
Copy link
Contributor

@mewtaylor Yes, I don't think this is really an hoc issue, just figured I'd log it. I think we should postpone to homepage redesign.

@jwzimmer-zz
Copy link
Contributor

@carljbowman confirmed the title/ button alignment is good as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants