-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create HOC Homepage Banner #981
Comments
Logged-in State
Desktop - 12col'Get Creative with Coding' Banner
'Design a Character' Event Row
Tablet to Desktop - 8col'Get Creative with Coding' Banner
'Design a Character' Event Row
Mobile to Tablet - 6col'Get Creative with Coding' Banner
'Design a Character' Event Row
Mobile - 4col'Get Creative with Coding' Banner
'Design a Character' Event Row
Non-logged-in State
Desktop
|
* feature/gh-981: Add hoc banner Move padding to splash element trello-ize title banner h1,p styling # Conflicts: # src/components/title-banner/title-banner.scss # src/views/hoc/hoc.jsx
TestingDesign diffs
Functionality
Responsiveness
Localization
Other
Compatibility
|
@jwzimmer - Thanks for logging the diffs. Both are okay.
|
Added in #1073 |
Fixes scratchfoundation#1078. This also fixes scratchfoundation#1076 and scratchfoundation#981 (comment) by updating the styling accordingly.
On Mobile checked with Nexus 5X (Android 7.0):
|
@chrisgarrity cool thanks – looks like this is a splash page problem (see the news box), which probably merits its own issue. Unless we want to just say it'll be addressed in the homepage redesign? |
@mewtaylor Yes, I don't think this is really an hoc issue, just figured I'd log it. I think we should postpone to homepage redesign. |
@carljbowman confirmed the title/ button alignment is good as-is. |
New banner at the top of the homepage that will be present for the two weeks around Hour of Code. This will contain links to the new T3 page, as well as specific resources to get started with (in the form of new tiles, as specified in #979).
Components to use:
The text was updated successfully, but these errors were encountered: