Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create HOC Homepage Event Row #982

Closed
mewtaylor opened this issue Oct 24, 2016 · 8 comments
Closed

Create HOC Homepage Event Row #982

mewtaylor opened this issue Oct 24, 2016 · 8 comments
Assignees
@kaschm @jwzimmer-zz @mewtaylor @carljbowman
Labels
feature needs-qa
Milestone
November 21 (hotf...

Comments

@mewtaylor
Copy link
Contributor

For Hour of Code this year, we will include a new row on the homepage that will link to a new studio, and include some video content. The row will be:

  • After the Featured Studios row
  • Dismissable
  • Only visible to logged in users
@mewtaylor mewtaylor added this to the November 21 (hotfix 12/1) milestone Oct 24, 2016
@mewtaylor mewtaylor mentioned this issue Oct 24, 2016
Closed
@carljbowman
Copy link
Contributor

Event Row

r2 0_event-row

r2 0_event-row grid

@coke11
Copy link

coke11 commented Oct 26, 2016

@mewtaylor Anyway I could help out with this?

@mewtaylor
Copy link
Contributor Author

@coke11 thanks so much for the offer but I think @carljbowman and I are all set!

@carljbowman
Copy link
Contributor

@mewtaylor - Here are those specs and assets

Desktop - 12col

Banner is 12col
Text is 5col
Video is 5col

r2 0_event-banner 12col-nogrid

r2 0_event-banner 12col

Tablet to Desktop - 8col

Banner is 8col
Text is 3col
Video is 4col

r2 0_event-banner 8col

Mobile to Tablet - 6col

Banner is 6col
Text is 5col
Video is 5col

r2 0_studio-banner 6col

Mobile - 4col

Banner is 4col
Text is 3col
Video is 3col

r2 0_studio-banner 4col

Background Asset

character-studio-bg

@mewtaylor
Copy link
Contributor Author

@carljbowman @kaschm do we have the video link too?

@jwzimmer-zz jwzimmer-zz self-assigned this Nov 22, 2016
@mewtaylor mewtaylor mentioned this issue Nov 29, 2016
Merged
mewtaylor added a commit that referenced this issue Nov 29, 2016
@mewtaylor
Merge pull request #1081 from mewtaylor/feature/gh-982
eb21456 
Implement GH-982: Add hoc event row
@jwzimmer-zz
Copy link
Contributor

Testing

  • Event row is on Staging with placeholder video
  • The row doesn't dismiss, @mewtaylor is fixing

@jwzimmer-zz
Copy link
Contributor

Testing continued in #1081 (to be consistent with where the test cases @mewtaylor wrote are).

@mewtaylor
Copy link
Contributor Author

Implemented in #1081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaschm kaschm

@jwzimmer-zz jwzimmer-zz

@mewtaylor mewtaylor

@carljbowman carljbowman

Labels
feature needs-qa
Projects
None yet
Milestone
November 21 (hotfix 12/1)
Development

No branches or pull requests
5 participants
@kaschm @jwzimmer-zz @mewtaylor @carljbowman @coke11