Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange state where HOC banner tiles are hidden but banner & homepage rows are extremely long #1084

Closed
jwzimmer-zz opened this issue Nov 29, 2016 · 0 comments
Labels
Milestone

Comments

@jwzimmer-zz
Copy link
Contributor

jwzimmer-zz commented Nov 29, 2016

Staging (soon to be Production too), IE 11 on Win 7 VM (@carljbowman & I did not see this in Chrome or Firefox)

This occurs at the lower threshold of the desktop size. If you drag the browser window until it is about 834 x 503, the banner will be extremely long and the tiles will be hidden. Note the tiny scroll bar width (indicating very long page width) at the bottom of the screen. If you refresh the page, the state does not change.

Note that this doesn't seem to be HOC-banner-specific - the whole page is strange looking at this size. The homepage rows are not correct either.

I think it's an issue with how we're detecting what state the browser is in (desktop, tablet, mobile) + IE 11, since this occurs right at the size border between desktop and tablet views.

screen shot 2016-11-29 at 12 17 25 pm

screen shot 2016-11-29 at 12 17 07 pm

screen shot 2016-11-29 at 12 16 52 pm

screen shot 2016-11-29 at 2 23 28 pm

@jwzimmer-zz jwzimmer-zz added this to the Backlog milestone Nov 29, 2016
@jwzimmer-zz jwzimmer-zz changed the title HOC banner - strange state where tiles are hidden but banner is extremely long Strange state where HOC banner tiles are hidden but banner & homepage rows are extremely long Nov 29, 2016
@jwzimmer-zz jwzimmer-zz removed this from the Backlog milestone Nov 29, 2016
@thisandagain thisandagain added this to the Backlog milestone Dec 12, 2016
@rschamp rschamp closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants