Implement GH-981: Temporary HOC Banner for Splash Page #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need it to be different for the hoc banner, so make it need a class name in order to be styled correctly
Having it in the nav was causing issues with positioning the banner, as evidenced by the teacher banner’s `-20px` setting
|
(Documenting QA for this in #981.) |
mewtaylor
added a commit
to mewtaylor/scratch-www
that referenced
this pull request
Dec 15, 2016
Merged
chirswomack
pushed a commit
to chirswomack/scratch-www
that referenced
this pull request
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1020