Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Add video embed to OER Work Type #931

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Conversation

ShanaLMoore
Copy link
Contributor

@ShanaLMoore ShanaLMoore commented Dec 6, 2023

This PR manually adds video embed to oer model, form files, and show partial.

It also includes translations.

Issue:

OER show page (OER does not use the base/show.html.erb like the other model types)

Vimeo example: https://player.vimeo.com/video/467264493?h=b089de0eab

image

This commit manually adds video embed to oer model and form files. TODO: figure out why including the VideoEmbedBehavior and the VideoEmbedForm modules don't work for OER.

Issue:
- #911
Base automatically changed from i911-video-embed-Image to main December 7, 2023 14:48
@ShanaLMoore ShanaLMoore marked this pull request as ready for review December 7, 2023 15:58
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Dec 7, 2023

UPDATE:

I'm noticing that editing the other work types is presenting the same behavior. For the sake of time I may undo the module work and proceed by putting the video embed code directly onto the models and form files, like done in this PR.

This commit uses VideoEmbedBehavior and VideoEmbedFormBehavior modules to DRY up the video_embed related code.
@ShanaLMoore ShanaLMoore merged commit 572d29b into main Dec 7, 2023
6 of 7 checks passed
@ShanaLMoore ShanaLMoore deleted the i911-video-embed-OER branch December 7, 2023 19:06
ShanaLMoore added a commit that referenced this pull request Dec 11, 2023
This commit is a follow up from PR:
- #931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants