Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Add fonts & colors in content blocks #923

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

laritakr
Copy link
Contributor

@laritakr laritakr commented Dec 6, 2023

Story

Updates the Tinymce options to include font selection, font size, and font color options.
Addresses a rubocop violation.

Refs: #843

Expected Behavior Before Changes

Screenshot 2023-12-05 at 11 44 33 PM

Expected Behavior After Changes

Screenshot 2023-12-05 at 11 54 01 PM

Screenshots / Video

Screenshot 2023-12-06 at 11 21 30 AM
Screenshot 2023-12-06 at 11 21 12 AM

Notes

Updates the Tinymce options to include font selection, font size, and
font color options.

Refs: #843
Copy link
Contributor

@jeremyf jeremyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to check if adding back color and fore color to the appearance text would then show in the UI?

I ask because there might be a HTML scrubbing going on, in which we specify what are the allowed tags in this block. My quick code scan for sanitize, strip, and scrub across Pals and Hyrax didn't show any likely "scrubbing" but I did want to double check.

@laritakr
Copy link
Contributor Author

laritakr commented Dec 6, 2023

Were you able to check if adding back color and fore color to the appearance text would then show in the UI?

I ask because there might be a HTML scrubbing going on, in which we specify what are the allowed tags in this block. My quick code scan for sanitize, strip, and scrub across Pals and Hyrax didn't show any likely "scrubbing" but I did want to double check.

Adding screenshots above.

@laritakr laritakr merged commit de17484 into main Dec 6, 2023
5 of 7 checks passed
@laritakr laritakr deleted the content-block-color-and-font branch December 6, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants