Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed codes for media (see Atla instance) #911

Closed
10 of 19 tasks
Tracked by #903
jillpe opened this issue Nov 30, 2023 · 7 comments
Closed
10 of 19 tasks
Tracked by #903

Embed codes for media (see Atla instance) #911

jillpe opened this issue Nov 30, 2023 · 7 comments

Comments

@jillpe
Copy link

jillpe commented Nov 30, 2023

Summary

relevant tickets

Pals would like to have the ability to embed YouTube videos onto a work show page, and they would like it to be implemented like Atla.

The tagged PRs are:

Task Breakdown

Acceptance Criteria

  • As a user, I can add a link to a youtube video I would like to embed on the edit work form
  • - [ ] As a user, I can add a link to a vimeo video I would like to embed on the edit work form
  • As a user, i can add a column to bulkrax csv import that allows me to import a embedded video url (youtube and/or vimeo) that will be used in an iframe.
  • As a user, I can visit that work's work-show page to see & play the embedded videos iframe
  • Client is sent the correct info for what column to add to bulkrax csvs.
  • Atla PRs that are related to this are added to Pals
  • all work types are able to embed videos
  • all themes show the embedded video
  • embed links must be valid. A user cannot submit the form if not.

Testing Instructions

BULKRAX

Import a sample CSV, but add a column called video_embed. The values will be the embed links from youtube and/or vimeo.
After the jobs finish processing, navigate to the works' show pages to confirm the videos are there and playable.

OTHER

Either create works from scratch, and/or edit previously imported works. Add or change the video_embed field.

THEMES

After having a hand full of created works with video embeds, change the tenant's show theme.

@jillpe jillpe converted this from a draft issue Nov 30, 2023
@jillpe
Copy link
Author

jillpe commented Nov 30, 2023

Can you give us more details here? Screenshots/videos are also welcome :)

@aahurford
Copy link
Collaborator

I reached out to Christy K at Atla for more info

@aahurford
Copy link
Collaborator

They do not have a live example, but here is a ticket that refers to the work: scientist-softserv/atla-hyku#34

@ShanaLMoore ShanaLMoore self-assigned this Dec 5, 2023
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
This commit allows videos to be embedded into a Generic Work. When the value is present, an embedded video should display.

related:
- https://github.com/scientist-softserv/atla-hyku/pull/34/files

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
This commit allows videos to be embedded into a Generic Work. When the value is present, an embedded video should display.

related:
- https://github.com/scientist-softserv/atla-hyku/pull/34/files

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
Adds video embed to CDL work type.

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
Adds video embed to CDL work type.

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
Adds video embed to CDL work type.

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
addd video embedding to ETD work type

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
This commit updates the scholarly theme's show page to handle video embed

Issue:
- #911
ShanaLMoore added a commit that referenced this issue Dec 6, 2023
This commit manually adds video embed to oer model and form files. TODO: figure out why including the VideoEmbedBehavior and the VideoEmbedForm modules don't work for OER.

Issue:
- #911
@ShanaLMoore ShanaLMoore moved this from Ready for Development to Deploy to Staging in palni-palci Dec 7, 2023
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to SoftServ QA in palni-palci Dec 7, 2023
@kirkkwang
Copy link
Contributor

kirkkwang commented Dec 11, 2023

QA status ✅

Looks good to me, all works are showing up with the video player, tested with youtube and vimeo

Image

@ShanaLMoore ShanaLMoore moved this from SoftServ QA to PALs QA in palni-palci Dec 11, 2023
@ndroark
Copy link
Collaborator

ndroark commented Dec 12, 2023

Would it be difficult to move the Video Embed to the Additional Fields section instead of the top section on the work upload form?

@ShanaLMoore
Copy link
Contributor

sure, fix coming soon!

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Dec 12, 2023

@ndroark Video embed is no longer above the additional fields. This is ready for your re-review.

demo: https://demo.commons-archive.org/concern/generic_works?locale=en

Image

@ndroark ndroark moved this from PALs QA to Deploy to Production in palni-palci Dec 12, 2023
@jeremyf jeremyf moved this from Deploy to Production to Client Verification in palni-palci Dec 13, 2023
jeremyf added a commit that referenced this issue Dec 18, 2023
Prior to this commit, we had a case where `<% render` was called.  The
result would be that we would in fact not render the results.

In the [file from PR 930][1] the render moved from `<%= render` to `<%
render`

With this commit, we restore that rendering.

Related to:

- #930
- #911

[1]: https://github.com/scientist-softserv/palni-palci/pull/930/files#diff-521d4c52bd51d0f13962e2d0b09d2740a257187d4fbf7b1fd8cff53e36b1362e
jeremyf added a commit to samvera/hyku that referenced this issue Dec 18, 2023
@ndroark ndroark moved this from Client Verification to Done in palni-palci Dec 18, 2023
@jeremyf jeremyf closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

6 participants