Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description does not show with PDF.js in Scholarly view page #823

Closed
ndroark opened this issue Sep 25, 2023 · 0 comments
Closed

Description does not show with PDF.js in Scholarly view page #823

ndroark opened this issue Sep 25, 2023 · 0 comments
Assignees
@kirkkwang
Labels
bug Something isn't working

Comments

@ndroark
Copy link
Collaborator

ndroark commented Sep 25, 2023 •
edited
Loading

When a work has the PDJ.js viewer turned on, the Description field is deprecated when using the Scholarly Show Page theme. Expected behavior is that this field will appear whether viewer is enabled or not.
@ndroark ndroark converted this from a draft issue Sep 25, 2023
@ndroark ndroark added the bug Something isn't working label Sep 25, 2023
@ndroark ndroark changed the title Description does now show with PDF.js in Scholarly view page Description does not show with PDF.js in Scholarly view page Sep 25, 2023
@kirkkwang kirkkwang self-assigned this Sep 25, 2023
@kirkkwang kirkkwang mentioned this issue Sep 25, 2023
Merged
@jillpe jillpe moved this from Ready for Development to PALs QA in palni-palci Sep 26, 2023
@ndroark ndroark moved this from PALs QA to Done in palni-palci Sep 29, 2023
@jillpe jillpe closed this as completed Oct 3, 2023
@ShanaLMoore ShanaLMoore mentioned this issue Nov 3, 2023
Closed
jeremyf added a commit to samvera/hyku that referenced this issue Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
0d6dbe7 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <[email protected]>
Co-authored-by: LaRita Robinson <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
Co-authored-by: Shana Moore <[email protected]>
jeremyf added a commit to samvera/hyku that referenced this issue Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
707b447 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <[email protected]>
Co-authored-by: LaRita Robinson <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
Co-authored-by: Shana Moore <[email protected]>
jeremyf added a commit to samvera/hyku that referenced this issue Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
1342260 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <[email protected]>
Co-authored-by: LaRita Robinson <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
Co-authored-by: Shana Moore <[email protected]>
jeremyf added a commit to samvera/hyku that referenced this issue Dec 19, 2023
@jeremyf @labradford
@laritakr @kirkkwang @ShanaLMoore
🎁 Contributions from PALNI/PALCI
6f9b88b 
Contribute back the following features:

- scientist-softserv/palni-palci#445
- scientist-softserv/palni-palci#659
- scientist-softserv/palni-palci#740
- scientist-softserv/palni-palci#748
- scientist-softserv/palni-palci#823
- scientist-softserv/palni-palci#843
- scientist-softserv/palni-palci#844
- scientist-softserv/palni-palci#911

Which were resolved via the following PRs:

- scientist-softserv/palni-palci#920
- scientist-softserv/palni-palci#704
- scientist-softserv/palni-palci#706
- scientist-softserv/palni-palci#790
- scientist-softserv/palni-palci#867
- scientist-softserv/palni-palci#874
- scientist-softserv/palni-palci#893
- scientist-softserv/palni-palci#898
- scientist-softserv/palni-palci#824
- scientist-softserv/palni-palci#923
- scientist-softserv/palni-palci#939
- scientist-softserv/palni-palci#922
- scientist-softserv/palni-palci#926
- scientist-softserv/palni-palci#927
- scientist-softserv/palni-palci#928
- scientist-softserv/palni-palci#929
- scientist-softserv/palni-palci#930
- scientist-softserv/palni-palci#931
- scientist-softserv/palni-palci#943
- scientist-softserv/palni-palci#945
- scientist-softserv/palni-palci#954

Co-authored-by: Lea Ann Bradford <[email protected]>
Co-authored-by: LaRita Robinson <[email protected]>
Co-authored-by: Kirk Wang <[email protected]>
Co-authored-by: Shana Moore <[email protected]>
This was referenced Dec 19, 2023
Closed
Closed
This was referenced Jan 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirkkwang kirkkwang

Labels
bug Something isn't working
Projects
palni-palci
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kirkkwang @jillpe @ndroark