Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended configuration to TaskTypes (backend only) #3415

Merged
merged 5 commits into from
Nov 1, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 29, 2018

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • tasktype json should contain new optional field recommendedConfiguration (JSON)
  • should also be read from form post request

Issues:


  • [ ] Updated changelog (let’s do that in the frontend part)
  • Updated migration guide if applicable
  • [ ] Updated documentation if applicable
  • [ ] Needs datastore update after deployment
  • Ready for review

@fm3 fm3 self-assigned this Oct 29, 2018
@fm3 fm3 added the backend label Oct 29, 2018
@fm3 fm3 changed the title [WIP] Add recommended configuration to TaskTypes Add recommended configuration to TaskTypes (backend only) Oct 29, 2018
@fm3 fm3 requested a review from rschwanhold October 29, 2018 12:56
Copy link
Contributor

@rschwanhold rschwanhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit 57a21ba into master Nov 1, 2018
@fm3 fm3 deleted the tasktype-recommended-configuration branch November 1, 2018 12:20
jfrohnhofen added a commit that referenced this pull request Nov 14, 2018
* master:
  remove -v (verbose) from backend-tests in CI (#3425)
  Add recommended configuration to TaskTypes (backend only) (#3415)
  Even if initialData is disabled, insert local stores (#3421)
  Add REST API docs (#3376)
  clearer message when annotation couldnt be found while logged out (#3413)
  prepare release 18.11.0 (#3414)
  Handle Cross-Datastore Duplicates, introducing scratch datastores (#3394)
  restrict user visibility (#3389)
  Add REST API versioning support (second try) (#3408)
  Enable hybrid tracings by default (#3399)
jfrohnhofen added a commit that referenced this pull request Nov 14, 2018
* isosurface:
  expose voxel dimensions as parameter, proper scale, #3313
  remove -v (verbose) from backend-tests in CI (#3425)
  Add recommended configuration to TaskTypes (backend only) (#3415)
  Even if initialData is disabled, insert local stores (#3421)
  Add REST API docs (#3376)
  clearer message when annotation couldnt be found while logged out (#3413)
  prepare release 18.11.0 (#3414)
  Handle Cross-Datastore Duplicates, introducing scratch datastores (#3394)
  restrict user visibility (#3389)
  Add REST API versioning support (second try) (#3408)
  Enable hybrid tracings by default (#3399)
@youri-k youri-k mentioned this pull request Nov 22, 2018
2 tasks
fm3 pushed a commit that referenced this pull request Nov 22, 2018
* add annotation dataset foreign key and fix pull number from #3415

* add pr number to evolution and update migration #3482

* Update 035-add-annotation-dataset-foreign-key.sql

* Update 035-add-annotation-dataset-foreign-key.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants