Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST API docs #3376

Merged
merged 9 commits into from
Oct 30, 2018
Merged

Add REST API docs #3376

merged 9 commits into from
Oct 30, 2018

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Oct 18, 2018

Should be merged only after #3385 .

https://docs.webknossos.org/v/doc-rest-api/reference/rest_api

Issues:


@fm3 fm3 added the backend label Oct 18, 2018
@fm3 fm3 self-assigned this Oct 18, 2018
@fm3 fm3 mentioned this pull request Oct 23, 2018
1 task
@fm3 fm3 changed the title [WIP] add rest api doc Add REST API docs Oct 23, 2018
Copy link
Contributor

@jfrohnhofen jfrohnhofen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a lot of routes. But documentation looks very good. Only left four minor remarks.

docs/rest_api.md Outdated
#### Expects
- Optional GET parameter `isEditable=[BOOLEAN]`
- If true: list only users for which you can change team memberships
- If false: list only users for which you can not change team memberships
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cannot

Suggested change
- If false: list only users for which you can not change team memberships
- If false: list only users for which you cannot change team memberships

docs/rest_api.md Outdated
#### Expects
- Optional GET parameter `isEditable=[BOOLEAN]`
- If true: list only datasets you can edit
- If false: list only datasets you can not edit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- If false: list only datasets you can not edit
- If false: list only datasets you cannot edit

docs/rest_api.md Outdated

#### Note

For each attached NML file, one task is created. This request will also return status code 200 if some tasks could not be created. Failed tasks are instead encoded in the JSON response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this. Above it says "Create tasks without attached NML files" but here we talk about NMLs?

- JSON object with four optional fields:
- `"user"` `[STRING]` show only tasks on which the user with this id has worked
- `"project"` `[STRING]` show only tasks of the project with this name
- `"ids"` `[JSON LIST OF STRINGS]` show only tasks with these ids
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent with LIST[STRING] used above

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(changed the one above)

@fm3
Copy link
Member Author

fm3 commented Oct 25, 2018

note to self: also reduce indent of second point in task createFromFiles

@fm3 fm3 merged commit fd0dff1 into master Oct 30, 2018
@fm3 fm3 deleted the api-doc branch October 30, 2018 06:48
jfrohnhofen added a commit that referenced this pull request Nov 14, 2018
* master:
  remove -v (verbose) from backend-tests in CI (#3425)
  Add recommended configuration to TaskTypes (backend only) (#3415)
  Even if initialData is disabled, insert local stores (#3421)
  Add REST API docs (#3376)
  clearer message when annotation couldnt be found while logged out (#3413)
  prepare release 18.11.0 (#3414)
  Handle Cross-Datastore Duplicates, introducing scratch datastores (#3394)
  restrict user visibility (#3389)
  Add REST API versioning support (second try) (#3408)
  Enable hybrid tracings by default (#3399)
jfrohnhofen added a commit that referenced this pull request Nov 14, 2018
* isosurface:
  expose voxel dimensions as parameter, proper scale, #3313
  remove -v (verbose) from backend-tests in CI (#3425)
  Add recommended configuration to TaskTypes (backend only) (#3415)
  Even if initialData is disabled, insert local stores (#3421)
  Add REST API docs (#3376)
  clearer message when annotation couldnt be found while logged out (#3413)
  prepare release 18.11.0 (#3414)
  Handle Cross-Datastore Duplicates, introducing scratch datastores (#3394)
  restrict user visibility (#3389)
  Add REST API versioning support (second try) (#3408)
  Enable hybrid tracings by default (#3399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some documentation for REST API
2 participants