Add REST API versioning support (second try) #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrohnhofen
approved these changes
Oct 26, 2018
jfrohnhofen
added a commit
that referenced
this pull request
Nov 14, 2018
* master: remove -v (verbose) from backend-tests in CI (#3425) Add recommended configuration to TaskTypes (backend only) (#3415) Even if initialData is disabled, insert local stores (#3421) Add REST API docs (#3376) clearer message when annotation couldnt be found while logged out (#3413) prepare release 18.11.0 (#3414) Handle Cross-Datastore Duplicates, introducing scratch datastores (#3394) restrict user visibility (#3389) Add REST API versioning support (second try) (#3408) Enable hybrid tracings by default (#3399)
jfrohnhofen
added a commit
that referenced
this pull request
Nov 14, 2018
* isosurface: expose voxel dimensions as parameter, proper scale, #3313 remove -v (verbose) from backend-tests in CI (#3425) Add recommended configuration to TaskTypes (backend only) (#3415) Even if initialData is disabled, insert local stores (#3421) Add REST API docs (#3376) clearer message when annotation couldnt be found while logged out (#3413) prepare release 18.11.0 (#3414) Handle Cross-Datastore Duplicates, introducing scratch datastores (#3394) restrict user visibility (#3389) Add REST API versioning support (second try) (#3408) Enable hybrid tracings by default (#3399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3404
Steps to test:
Changes to standalone datastore setup
add these three lines to the end of your application.conf (no changes needed in routes file anymore)
Changes necessary in kube
play.http.routershould be changed to"noDS.noTS.Routes"for mhlab, as they don’t have a local datastore nor tracingstore. see Migrations.md[] Updated changelog[ ] Updated documentation if applicable[ ] Needs datastore update after deployment