-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-ticket: Refactor and improve system package related scripts, tox.ini, build/bin/write_dockerfile.sh #29146
Labels
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mkoeppe
changed the title
Refactor build/bin/write_dockerfile.sh
Refactor tox.ini and build/bin/write_dockerfile.sh
Mar 20, 2020
This comment has been minimized.
This comment has been minimized.
mkoeppe
changed the title
Refactor tox.ini and build/bin/write_dockerfile.sh
Meta-ticket: Refactor tox.ini and build/bin/write_dockerfile.sh
Mar 29, 2020
mkoeppe
changed the title
Meta-ticket: Refactor tox.ini and build/bin/write_dockerfile.sh
Meta-ticket: Refactor system package related scripts, tox.ini, build/bin/write_dockerfile.sh
Mar 29, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dependencies: #29417 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mkoeppe
changed the title
Meta-ticket: Refactor system package related scripts, tox.ini, build/bin/write_dockerfile.sh
Meta-ticket: Refactor and improve system package related scripts, tox.ini, build/bin/write_dockerfile.sh
Apr 25, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:39
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Oct 12, 2023
…-{in,ex}clude-dependencies` We enhance the command `sage --package list`: - New switches `--{in,ex}clude-dependencies` walk the tree of dependencies declared in `dependencies` files - Output is always (uniquified and) sorted, eliminating the use of `sort` in various scripts - Handling of `--exclude` is moved to the end, which improves its applicability. The new parsing of the `dependencies*` files in `sage_bootstrap` is generic preparation for handling more of the bootstrapping phase in Python, as sketched in sagemath#33860 (part of sagemath#29146). This PR is immediate preparation for sagemath#35593, where it is desired to create "minimized" lists of system packages that do not include all standard packages that are really only needed as dependencies of "top- level" packages. <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36393 Reported by: Matthias Köppe Reviewer(s): Michael Orlitzky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Improvements to low-level system packages scripts:
tox.ini
,build/bin/write_dockerfile.sh
by extending and usingsage_bootstrap
build/bin/sage-print-system-package-command
so that it can provide all distribution-specific commands such asapt-get install
forbuild/bin/write_dockerfile.sh
Improvements to the system package database:
debian.txt
IGNORE_MISSING_PACKAGES=yes
Improvements to
tox docker
:docker run
instead of aDockerfile
(this gives more flexibility for multiarch - see tox.ini update: Fix breakage caused by src/ext move, add 32-bit linux environments and other architectures supported by docker #29143)docker ps --filter label=....
to look up the container (https://docs.docker.com/engine/reference/commandline/ps/)TARGETS_PRE
/TARGETS
distinction: Instead leave a stamp file and exit from make with an error to trigger the ADD of src/; for example, addsagelib
dependency on$(SAGE_SRC)/sage
, and add the rule to Makefile:MAKE
for docker builds as well, instead of asking users to pass theUSE_MAKEFLAGS
variableImprovements to
tox local
:ci-cygwin*.yml
: delegate totox
, add more stages, use more specificSAGE_LOCAL
local
consists entirely of workarounds for things that should really be fixed/improved in ourMakefile
s:build/make/Makefile.in
:base-toolchain
should be a dependency of every non-base, non-toolchain packagetox.ini
andbuild/bin/write-dockerfile.sh
use better defaults forSAGE_CHECK_PACKAGES
; this should be moved tobuild/make/Makefile.in
(SAGE_CHECK_PACKAGES_DEFAULT_yes
).Other improvements to
tox.ini
:tox -p auto
andtox --listenvs
useful again (it does not understand the nested braces)tox.ini
,build/bin/write-dockerfile.sh
: Do not usemake -k
by defaultImprovements to auto-generated parts of the manuals:
_recommended
and generate "recommended system packages" infoImprovements for messages at the end of a
./configure
run:sage-guess-package-system
: Ignore conda if no environment is activatedsage-guess-package-system
should report several package systems such asconda ubuntu
orhomebrew cpan
when that makes senseconfigure
, indicate which optional/experimental packages are configured to be installedconfigure
, show installation hints for disabled optional packages separatelyconfigure
: Change defaults to--with-system-gcc=force
,--with-system-python3=force
Tickets regarding
sage_bootstrap
:sage_bootstrap
: Remove Python 2.6 supportsage --package
: Add commandslist :standard:
,update-latest
(for packages from PyPI),upload
See also:
Depends on #29417
CC: @embray @vbraun @dimpase @jhpalmieri @sheerluck @slel @tobiasdiez @seblabbe
Component: build
Branch/Commit: u/mkoeppe/meta_ticket__refactor_and_improve_system_package_related_scripts__tox_ini__build_bin_write_dockerfile_sh @
fd9b928
Issue created by migration from https://trac.sagemath.org/ticket/29146
The text was updated successfully, but these errors were encountered: