-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore "huge" package type #29919
Comments
This comment has been minimized.
This comment has been minimized.
comment:5
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Commit: |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Can you document both |
comment:15
Good idea |
comment:16
I think we should have a cleaner way to add "tags" to packages, but in lieu of general solution this gets the job done. The nonfree-dependencies thing is a bit of a legal mess. Users who install such a package lose the right to distribute their copy of sage. Entities such as universities may not want to wade into that sort of grey area. Anyway, that's orthogonal to this ticket. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:20
Would
be more efficient than the current
and similarly a few lines later with |
comment:21
Never mind, I guess it doesn't matter. |
comment:22
There's no difference in efficiency - both |
comment:23
I got confused and thought that the two might short-circuit at different points, but they will short-circuit at exactly the same point, so it makes no difference. This is not your fault and should not be fixed on this ticket, but I wish that the code in |
Reviewer: John Palmieri |
comment:24
Thanks! |
Changed branch from u/mkoeppe/restore__huge__package_type to |
(from #29901)
... for packages like
database_stein_watkins
andpolytopes_db_4d
Parts of
sage_bootstrap
know about this package type, but other scripts don't.Our GH Actions scripts filter out these packages by name. This can be refactored.
With the present ticket, we can now say
sage --package list :optional: :experimental: --no-file huge
to filter out the huge packages.Huge packages are now marked by the presence of the file
huge
; so this is actually orthogonal to the package type.We also add files named
has_nonfree_dependencies
to some other packages so that they can be filtered out by the same mechanism.CC: @jhpalmieri @dimpase @orlitzky @seblabbe @Etn40ff @tobiasdiez
Component: build
Author: Matthias Koeppe
Branch/Commit:
15cc20c
Reviewer: John Palmieri
Issue created by migration from https://trac.sagemath.org/ticket/29919
The text was updated successfully, but these errors were encountered: