Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAGE_ROOT/tox.ini: Make tox -p auto and tox --listenvs useful again #32764

Closed
mkoeppe opened this issue Oct 25, 2021 · 14 comments
Closed

SAGE_ROOT/tox.ini: Make tox -p auto and tox --listenvs useful again #32764

mkoeppe opened this issue Oct 25, 2021 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 25, 2021

(from #29146)

tox does not actually understand the nested braces used in envlist.

https://groups.google.com/g/sage-devel/c/NU-xlUTIIdE/m/Q14HiKvNAgAJ

CC: @jhpalmieri @kliem

Component: porting

Author: Matthias Koeppe

Branch/Commit: 47a2b42

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/32764

@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 25, 2021
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2021

Commit: 5392cd7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5392cd7tox.ini: Do not include the environments delegated to src/tox.ini in 'tox -p auto'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2021

comment:5

Here's an attempt at improving the tox -p auto situation and documentation.
Please feel free to push further changes to this ticket

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

47a2b42tox.ini: Add more examples

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2021

Changed commit from 5392cd7 to 47a2b42

@jhpalmieri
Copy link
Member

comment:9

Was the hope that the nested braces would allow testing all of the various combinations via tox -p auto?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 4, 2021

comment:10

Yes, and some early version of it did something like that. https://tox.wiki/en/latest/config.html#generative-section-names
Not sure if nesting ever worked.

@jhpalmieri
Copy link
Member

comment:11

I could imagine expanding that environment list (since it's much shorter now than the original intention), but that can wait.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 4, 2021

comment:12

Thanks!

@vbraun
Copy link
Member

vbraun commented Nov 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants