-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SafeWebAuthnSignerProxy #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-ap
requested review from
nlordell,
mmv08 and
remedcu
and removed request for
a team
April 8, 2024 12:15
Pull Request Test Coverage Report for Build 8784802120Details
💛 - Coveralls |
nlordell
reviewed
Apr 9, 2024
akshay-ap
force-pushed
the
feature-312-webAuthn-proxy
branch
4 times, most recently
from
April 9, 2024 13:13
d986d03
to
9f257b6
Compare
nlordell
reviewed
Apr 9, 2024
nlordell
reviewed
Apr 9, 2024
akshay-ap
force-pushed
the
feature-312-webAuthn-proxy
branch
2 times, most recently
from
April 10, 2024 15:06
cc1b1ef
to
c762ed0
Compare
nlordell
reviewed
Apr 10, 2024
nlordell
reviewed
Apr 10, 2024
nlordell
reviewed
Apr 11, 2024
akshay-ap
force-pushed
the
feature-312-webAuthn-proxy
branch
4 times, most recently
from
April 11, 2024 12:28
b6446de
to
a016b8a
Compare
@akshay-ap - can you rebase the PR, it would help with the review process. |
akshay-ap
force-pushed
the
feature-312-webAuthn-proxy
branch
2 times, most recently
from
April 18, 2024 14:10
c3c73b5
to
4a2fc48
Compare
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
akshay-ap
force-pushed
the
feature-312-webAuthn-proxy
branch
from
April 22, 2024 15:30
bdcd413
to
96ccadc
Compare
nlordell
reviewed
Apr 23, 2024
nlordell
reviewed
Apr 23, 2024
nlordell
reviewed
Apr 23, 2024
nlordell
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed when running locally that there are compiler warning that can be resolved.
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
nlordell
reviewed
Apr 23, 2024
nlordell
reviewed
Apr 23, 2024
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
This reverts commit 1aee6ee.
nlordell
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312
Changes in PR:
Create
SafeWebAuthnSignerSingleton
. This contract has no storage, no immutables, and no constants.Create
SafeWebAuthnSignerProxy
and corresponding proxy factory i.e.SafeWebAuthnSignerProxyFactory
Create immutable
singleton
contract when deploying proxy factorySafeWebAuthnSignerProxyFactory.isValidSignatureForSigner(...)
forwards to singleton contract instead directly callingWebAuthn
librarySafeWebAuthnSignerProxy
uses no storage to avoid 4337 storage access restriction violation.Add unit test to verify that
SafeWebAuthnSignerProxy
forwards every call to singleton addressReport gas usage metrics
Update github workflow to execute benchmarking tests separately. (This is required to get accurate gas usage numbers)
Update documentation
Replace
SafeWebAuthnSigner
withSafeWebAuthnSignerProxy
, same for factory contractUpdate all tests to use
SafeWebAuthnSignerProxy
. Hence, the large diff in this PR.Benchmark number from this PR:
Benchmark number from main: