Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SafeWebAuthnSignerProxy #370

Merged
merged 53 commits into from
Apr 23, 2024
Merged

Create SafeWebAuthnSignerProxy #370

merged 53 commits into from
Apr 23, 2024

Commits on Apr 22, 2024

  1. [#312] Create SafeWebAuthnSignerProxy

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5f2786a View commit details
    Browse the repository at this point in the history

  2. [#312] Benchmark deployment, verification cost for proxy

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2be5087 View commit details
    Browse the repository at this point in the history

  3. Change test name

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    96aaf53 View commit details
    Browse the repository at this point in the history

  4. [#312] Use immutables for storing values

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a50bc54 View commit details
    Browse the repository at this point in the history

  5. [#312] Update natspec doc

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b07adfb View commit details
    Browse the repository at this point in the history

  6. [#312] Mark singleton as immutable

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    da30c7f View commit details
    Browse the repository at this point in the history

  7. [#312] Run benchmarking tests in separate job

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    cdf98ac View commit details
    Browse the repository at this point in the history

  8. [#312] Make signer singleton immutable

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    67e2063 View commit details
    Browse the repository at this point in the history

  9. [#312] Minor naming update in ci_passkey.yml

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    082f588 View commit details
    Browse the repository at this point in the history

  10. Update modules/passkey/contracts/SafeWebAuthnSignerProxyFactory.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    30ab2a3 View commit details
    Browse the repository at this point in the history

  11. [#312] Remove replace SafeWebAuthnSigner.sol with SafeWebAuthnSignerP… 

    …roxy.sol, same for factory
    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    14152c5 View commit details
    Browse the repository at this point in the history

  12. [#312] Remove SafeWebAuthnSigner

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    09c87c1 View commit details
    Browse the repository at this point in the history

  13. [#312] Return value if staticcall to singleton succeeds

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4573082 View commit details
    Browse the repository at this point in the history

  14. [#312] Add unit test for SafeWebAuthnSignerProxy

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    738ec46 View commit details
    Browse the repository at this point in the history

  15. [#312] Fix lint issue

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ecf5c9f View commit details
    Browse the repository at this point in the history

  16. [#312] Mention use of signer proxy in README.md

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b03e475 View commit details
    Browse the repository at this point in the history

  17. [#312] Fix faling tests

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7e2a6b6 View commit details
    Browse the repository at this point in the history

  18. [#312] Remove unused report

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5ee6d5e View commit details
    Browse the repository at this point in the history

  19. [#312] Fix failing test

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e6e6212 View commit details
    Browse the repository at this point in the history

  20. [#312] Fix lint issue, replace string with const

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0204c05 View commit details
    Browse the repository at this point in the history

  21. [#312] Remove singleton signer tests

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    84a7b97 View commit details
    Browse the repository at this point in the history

  22. [#312] Fix failing benchmarking tests

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f8bb9ed View commit details
    Browse the repository at this point in the history

  23. [#312] Rename Signer factory contract, update natspec doc, decode x,y… 

    …,verifier data in _verifySignature
    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    915276c View commit details
    Browse the repository at this point in the history

  24. [#312] Update README.md

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9e542ea View commit details
    Browse the repository at this point in the history

  25. [#312] Create public getters in singleton, mark proxy variables as in… 

    …ternal
    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    22b4e9f View commit details
    Browse the repository at this point in the history

  26. [#312] Rename variables in SafeWebAuthnSignerProxy.sol

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3ef74ee View commit details
    Browse the repository at this point in the history

  27. Update modules/passkey/contracts/SafeWebAuthnSignerProxy.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    103651c View commit details
    Browse the repository at this point in the history

  28. [#312] Update natspecdoc, rename var

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e64e265 View commit details
    Browse the repository at this point in the history

  29. [#312] Use single getter for public key and verifier address

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8818b46 View commit details
    Browse the repository at this point in the history

  30. Update modules/passkey/test/GasBenchmarkingProxy.spec.ts 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e9eccd5 View commit details
    Browse the repository at this point in the history

  31. Update modules/passkey/test/GasBenchmarkingProxy.spec.ts 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    75eec83 View commit details
    Browse the repository at this point in the history

  32. Update modules/passkey/test/userstories/OffchainPasskeyVerification.s… 

    …pec.ts

Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7e05b55 View commit details
    Browse the repository at this point in the history

  33. [#312] Use singleton so that contract points to correct abi

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9a72ab5 View commit details
    Browse the repository at this point in the history

  34. [#312] Fix variable name in Gas benchmarking proxy tests

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4e66ab6 View commit details
    Browse the repository at this point in the history

  35. [#312] Minor test refactor

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e45e7db View commit details
    Browse the repository at this point in the history

  36. [#312] Lint fixes

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    45b1eb8 View commit details
    Browse the repository at this point in the history

  37. [#312] Gas benchmarking updates

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b1f47a9 View commit details
    Browse the repository at this point in the history

  38. [#312] Fix dataOffset

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d1b713e View commit details
    Browse the repository at this point in the history

  39. Update modules/passkey/contracts/SafeWebAuthnSignerSingleton.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    37b87c1 View commit details
    Browse the repository at this point in the history

  40. Update modules/passkey/contracts/SafeWebAuthnSignerSingleton.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    680ea5b View commit details
    Browse the repository at this point in the history

  41. Update modules/passkey/test/SafeWebAuthnSignerProxy.spec.ts 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f000c79 View commit details
    Browse the repository at this point in the history

  42. Update modules/passkey/contracts/SafeWebAuthnSignerFactory.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4ba34fa View commit details
    Browse the repository at this point in the history

  43. [#312] Fix variable name

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9427756 View commit details
    Browse the repository at this point in the history

  44. [#312] Restore deleted files

    @akshay-ap
    akshay-ap committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    96ccadc View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. [#312] Use contract name instead of address in immutable type for Sin… 

    …gleton
    @akshay-ap
    akshay-ap committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f35a2eb View commit details
    Browse the repository at this point in the history

  2. Update modules/passkey/contracts/SafeWebAuthnSignerProxy.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    61822da View commit details
    Browse the repository at this point in the history

  3. Update modules/passkey/contracts/SafeWebAuthnSignerFactory.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c154ec4 View commit details
    Browse the repository at this point in the history

  4. Update modules/passkey/contracts/SafeWebAuthnSignerFactory.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1aee6ee View commit details
    Browse the repository at this point in the history

  5. Update modules/passkey/contracts/SafeWebAuthnSignerFactory.sol 

    Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
    @akshay-ap @nlordell
    akshay-ap and nlordell authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3138afc View commit details
    Browse the repository at this point in the history

  6. Revert "Update modules/passkey/contracts/SafeWebAuthnSignerFactory.sol" 

    This reverts commit 1aee6ee.
    @akshay-ap
    akshay-ap committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    505f0d6 View commit details
    Browse the repository at this point in the history

  7. [#312] Fix build error

    @akshay-ap
    akshay-ap committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a35771a View commit details
    Browse the repository at this point in the history

  8. [#312] Fix compiler warning

    @akshay-ap
    akshay-ap committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7ec427a View commit details
    Browse the repository at this point in the history

  9. [#312] Add comment

    @akshay-ap
    akshay-ap committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7c6bb57 View commit details
    Browse the repository at this point in the history