-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate Overhead Of Deploying WebAuthn Logic In Signer #312
Comments
Partially implemented in #320, where a code-size optimized We should still compare gas consumption against a minimal proxy implementation before deciding. Expected OutcomeA PR with a |
Closing issue, as the expected outcome has been achieved, and we decided to go with the proxy implementation. |
…,verifier data in _verifySignature
One reason to have the
WebAuthn
signer contract "proxy" the signature verification logic to aWebAuthnVerifier
(or the WebAuthn contract with #311) is to save on deployment gas.However, given a more optimal Base64 implementation in #289, it may not save that much deployment bytecode to merrit the separation.
This issue captures the work to analyze including WebAuthn logic directly in the
WebAuthnSigner
contract and evaluate the gas tradeoffs of doing so.The text was updated successfully, but these errors were encountered: