Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Overhead Of Deploying WebAuthn Logic In Signer #312

Closed
nlordell opened this issue Mar 7, 2024 · 2 comments · Fixed by #370
Closed

Evaluate Overhead Of Deploying WebAuthn Logic In Signer #312

nlordell opened this issue Mar 7, 2024 · 2 comments · Fixed by #370
Assignees

Comments

@nlordell
Copy link
Collaborator

nlordell commented Mar 7, 2024

One reason to have the WebAuthn signer contract "proxy" the signature verification logic to a WebAuthnVerifier (or the WebAuthn contract with #311) is to save on deployment gas.

However, given a more optimal Base64 implementation in #289, it may not save that much deployment bytecode to merrit the separation.

This issue captures the work to analyze including WebAuthn logic directly in the WebAuthnSigner contract and evaluate the gas tradeoffs of doing so.

@nlordell
Copy link
Collaborator Author

nlordell commented Mar 18, 2024

Partially implemented in #320, where a code-size optimized WebAuthn library implementation was introduced.

We should still compare gas consumption against a minimal proxy implementation before deciding.

Expected Outcome

A PR with a WebAuthnSigner implemented as a minimal proxy with gas analysis. Then, we should decide which implementation we prefer compared to #320.

akshay-ap added a commit that referenced this issue Apr 9, 2024
akshay-ap added a commit that referenced this issue Apr 9, 2024
akshay-ap added a commit that referenced this issue Apr 9, 2024
akshay-ap added a commit that referenced this issue Apr 9, 2024
akshay-ap added a commit that referenced this issue Apr 11, 2024
akshay-ap added a commit that referenced this issue Apr 11, 2024
akshay-ap added a commit that referenced this issue Apr 11, 2024
akshay-ap added a commit that referenced this issue Apr 11, 2024
akshay-ap added a commit that referenced this issue Apr 11, 2024
akshay-ap added a commit that referenced this issue Apr 11, 2024
@nlordell
Copy link
Collaborator Author

Closing issue, as the expected outcome has been achieved, and we decided to go with the proxy implementation.

akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
akshay-ap added a commit that referenced this issue Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants