Skip to content

Commit

Permalink
[#312] Fix lint issue, replace string with const
Browse files Browse the repository at this point in the history
  • Loading branch information
akshay-ap committed Apr 18, 2024
1 parent fcf5275 commit c3c73b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions examples/4337-passkeys/src/logic/safe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import { bytecode as SafeWebAuthnSignerSingletonBytecode } from '@safe-global/sa
import { abi as Safe4337ModuleAbi } from '@safe-global/safe-4337/build/artifacts/contracts/Safe4337Module.sol/Safe4337Module.json'
import { abi as SafeProxyFactoryAbi } from '@safe-global/safe-4337/build/artifacts/@safe-global/safe-contracts/contracts/proxies/SafeProxyFactory.sol/SafeProxyFactory.json'
import type { Safe4337Module, SafeModuleSetup, SafeProxyFactory } from '@safe-global/safe-4337/typechain-types/'
import type { SafeSignerLaunchpad, SafeWebAuthnSignerProxy,
SafeWebAuthnSignerProxyFactory } from '@safe-global/safe-passkey/typechain-types/'
import type { SafeSignerLaunchpad } from '@safe-global/safe-passkey/typechain-types/'

import {
P256_VERIFIER_ADDRESS,
Expand Down
3 changes: 2 additions & 1 deletion modules/passkey/test/GasBenchmarkingProxy.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { expect } from 'chai'
import { deployments, ethers } from 'hardhat'

import * as ERC1271 from './utils/erc1271'
import { WebAuthnCredentials } from './utils/webauthnShim'
import { decodePublicKey, encodeWebAuthnSignature } from '../src/utils/webauthn'
import { IP256Verifier } from '../typechain-types'
Expand Down Expand Up @@ -90,7 +91,7 @@ describe('Gas Benchmarking Proxy [@bench]', function () {
)

const [magicValue] = ethers.AbiCoder.defaultAbiCoder().decode(['bytes4'], returnData)
expect(magicValue).to.equal('0x1626ba7e')
expect(magicValue).to.equal(ERC1271.MAGIC_VALUE)

console.log(` ⛽ verification (${name}): ${gas}`)
})
Expand Down

0 comments on commit c3c73b5

Please sign in to comment.