Rollup of 7 pull requests #44761
Closed
Rollup of 7 pull requests #44761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NetBSD doesn't ship with sha256sum. The openssl build will probably try to use perl anyway, so using perl's shasum is reasonable.
Some tar(1) programs—such as NetBSD's—do not automatically decompress.
It's not a lang item anymore. Also remove outdated note.
If config.toml doesn't exist, then an IOError will be raised on the `with open(...)` line. Prior to e788fa7, this was caught because the `except` clause didn't specify what exceptions it caught, so both IOError and OSError were caught
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=10 |
|
📌 Commit 63d1fe7 has been approved by |
…d-8c68-1aecbd570fab, r=Mark-Simulacrum Fix extended bootstrap issues with OpenSSL on NetBSD build hosts
…uietMisdreavus Add pub visibility for methods as well Fixes rust-lang#44527. r? @QuietMisdreavus
GuillaumeGomez
force-pushed
the
rollup
branch
from
63d1fe7
to
1b55d19
Compare
Expand size_of docs This PR does 3 things. 1. Adds a description of what pointer size means to the primitive pages for usize and isize. 2. Says the general size of things is not stable from compiler to compiler. 3. Adds a table of sizes of things that we do guarantee. As this is the first table in the libstd docs, I've included a picture of how that looks. 
…, r=arielb1 Remove str_eq lang item It's not really a lang item. Also remove outdated note. The reference uses this as an example so it has to be updated.
fix an incorrect assertion in the doc example for `std::io::copy` I think this wasn't caught by CI because the `foo` wrapper function was only defined and not called. This seems to be the norm for doc examples that define a `foo` function. Is that on purpose?
…lies-emitendregions, r=arielb1 Make `-Z borrowck-mir` imply that `EndRegion`'s should be emitted. Before this change, the `-Z borrowck-mir` flag is useless if you do not also pass `-Z emit-end-regions`. So, in the same spirit as f2892ad, make `-Z borrowck-mir` also emit `EndRegion` statements. (This will hopefully avoid some initial speed bumps for new-comers helping out with NLL.)
Fix librustc/README.md diagram
…-fix, r=alexcrichton Catch IOError in bootstrap.py when loading config.toml When I pulled this repo and tried to build using the command in the readme, I got an error about a missing `config.toml`. If config.toml doesn't exist, then an `IOError` will be raised the `with open(...)` line. Prior to e788fa7, this was caught because the `except` clause didn't specify what exceptions it caught, so both `IOError` and `OSError` were caught. First time contributing, so please let me know if I'm doing anything wrong.
|
@bors: r+ p=10 |
|
📌 Commit 6754846 has been approved by |
|
⌛ Testing commit 6754846 with merge 40041c74049a7dc5c8b38e17893d0a3732e2028b... |
|
💔 Test failed - status-travis |
|
https://travis-ci.org/rust-lang/rust/jobs/278400957 |
|
I suppose it's a travis issue? Let's retry... @bors: retry |
|
⌛ Testing commit 6754846 with merge 670a6ab2d9c587d068caa5936a232baf5c79a048... |
|
💔 Test failed - status-travis |
|
It failed with the same error, and there is a PR in the rollup that talks about shasum... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::io::copy#44712, Make-Z borrowck-mirimply thatEndRegion's should be emitted. #44717, Fix librustc/README.md diagram #44726