Add pub visibility for methods as well

[GuillaumeGomez]

Fixes #44527.

r? @QuietMisdreavus

[QuietMisdreavus]

r=me pending travis

[QuietMisdreavus]

@bors r+ rollup

[bors]

📌 Commit 42a0286 has been approved by QuietMisdreavus

[ollie27]

The head_len part just above this will need to be updated as well. Also this could do with some tests.

[QuietMisdreavus]

@bors r-

Good catch, @ollie27. I hesitated asking for some tests, but it is a good idea.

[GuillaumeGomez]

@ollie27: Good catch!

[GuillaumeGomez]

However I have no idea how to test it...

[ollie27]

I'm not sure how to add tests for the indentation but a simple test like the following would be useful:

#![crate_name = "foo"]

pub struct Foo;

impl Foo {
    // @has 'foo/struct.Foo.html' '//code' 'pub fn f()'
    pub fn f() {}
}

[QuietMisdreavus]

I rummaged through the flags available to compiler tests and it looks like we can't add flags to rustdoc (to enable rendering private items), so for now that will have to do.

[ollie27]

@QuietMisdreavus do you mean like

rust/src/test/rustdoc/empty-mod-private.rs

Line 12 in 5dfc84c

// compile-flags: --no-defaults --passes collapse-docs --passes unindent-comments --passes strip-priv-imports

?

[QuietMisdreavus]

Um, yes, exactly that. I didn't realize that the compile-flags worked like that. So yeah, that's what i had in mind to be able to test rendering pub fn and fn distinctly.

[GuillaumeGomez]

Oh damn, I forgot to add the test file! Now I see what you're talking about...

[GuillaumeGomez]

I added the test.

[bors]

☔ The latest upstream changes (presumably #44585) made this pull request unmergeable. Please resolve the merge conflicts.

[QuietMisdreavus]

Could you add another bit to the test where it renders a non-pub function without "pub"? You can disable the strip-private pass using the suggestion from #44554 (comment) above.

[QuietMisdreavus]

(the test got updated to include a non-pub method, and travis passed, so:)

@bors r+

[bors]

📌 Commit 203d71f has been approved by QuietMisdreavus