fix an incorrect assertion in the doc example for std::io::copy
#44712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
oconnor663
commented
Sep 20, 2017
| @@ -40,9 +40,10 @@ use mem; | |||
| /// | |||
| /// io::copy(&mut reader, &mut writer)?; | |||
| /// | |||
| /// assert_eq!(reader, &writer[..]); | |||
There was a problem hiding this comment.
reader is an empty slice at this point.
|
It seems a bit weird that we'd be avoiding running this code to me as well. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit c9099ff has been approved by |
A lot of stuff in That said, this one seems fine to execute. |
aidanhs
added
the
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 21, 2017
fix an incorrect assertion in the doc example for `std::io::copy` I think this wasn't caught by CI because the `foo` wrapper function was only defined and not called. This seems to be the norm for doc examples that define a `foo` function. Is that on purpose?
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 23, 2017
fix an incorrect assertion in the doc example for `std::io::copy` I think this wasn't caught by CI because the `foo` wrapper function was only defined and not called. This seems to be the norm for doc examples that define a `foo` function. Is that on purpose?
bors
added a commit
that referenced
this pull request
Sep 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this wasn't caught by CI because the
foowrapper function was only defined and not called. This seems to be the norm for doc examples that define afoofunction. Is that on purpose?