Make -Z borrowck-mir imply that EndRegion's should be emitted.
#44717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup |
|
📌 Commit 66a31c7 has been approved by |
aidanhs
added
the
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 21, 2017
…lies-emitendregions, r=arielb1 Make `-Z borrowck-mir` imply that `EndRegion`'s should be emitted. Before this change, the `-Z borrowck-mir` flag is useless if you do not also pass `-Z emit-end-regions`. So, in the same spirit as f2892ad, make `-Z borrowck-mir` also emit `EndRegion` statements. (This will hopefully avoid some initial speed bumps for new-comers helping out with NLL.)
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 23, 2017
…lies-emitendregions, r=arielb1 Make `-Z borrowck-mir` imply that `EndRegion`'s should be emitted. Before this change, the `-Z borrowck-mir` flag is useless if you do not also pass `-Z emit-end-regions`. So, in the same spirit as f2892ad, make `-Z borrowck-mir` also emit `EndRegion` statements. (This will hopefully avoid some initial speed bumps for new-comers helping out with NLL.)
bors
added a commit
that referenced
this pull request
Sep 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the
-Z borrowck-mirflag is useless if you do not also pass-Z emit-end-regions.So, in the same spirit as f2892ad, make
-Z borrowck-miralso emitEndRegionstatements. (This will hopefully avoid some initial speed bumps for new-comers helping out with NLL.)