-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal links to README.md are broken #984
Comments
Ok, here's an example: |
Repro steps
|
duplicated issue? #1268 |
Yea, both issues are essentially the same. I'll keep this one, but there is some more context and discussion in #1268 that is worth reading. |
Including a workaround for rust-lang/mdBook#984
So what's the latest on this? I'm just seeing a circular loop of duplicate_of's and closed Issues that don't seem to go anywhere. Is there a way to resolve this currently? |
We use the built-in `index` preprocessor to rename our `README.md` files to `index.md`, but it doesn't currently fixup links: <rust-lang/mdBook#984>. This is a temporary preprocessor to regex replace those links until upstream gets fixed. Signed-off-by: Hugo McNally <[email protected]>
We use the built-in `index` preprocessor to rename our `README.md` files to `index.md`, but it doesn't currently fixup links: <rust-lang/mdBook#984>. This is a temporary preprocessor to regex replace those links until upstream gets fixed. Signed-off-by: Hugo McNally <[email protected]>
We use the built-in `index` preprocessor to rename our `README.md` files to `index.md`, but it doesn't currently fixup links: <rust-lang/mdBook#984>. This is a temporary preprocessor to regex replace those links until upstream gets fixed. Signed-off-by: Hugo McNally <[email protected]>
We use the built-in `index` preprocessor to rename our `README.md` files to `index.md`, but it doesn't currently fixup links: <rust-lang/mdBook#984>. This is a temporary preprocessor to regex replace those links until upstream gets fixed. Signed-off-by: Hugo McNally <[email protected]>
We use the built-in `index` preprocessor to rename our `README.md` files to `index.md`, but it doesn't currently fixup links: <rust-lang/mdBook#984>. This is a temporary preprocessor to regex replace those links until upstream gets fixed. Signed-off-by: Hugo McNally <[email protected]>
Just in case anybody stumbles upon the same issue: We use this one line in our ci script using find and sed (with extended regular expressions support):
Looks funky, but it just works :) |
Opinion: Mapping README.md to index.html seems fine, however if that is done then I think any links to
|
Any update? 😥 |
README.md
gets translated toindex.html
, but internal links (except for those inSUMMARY.md
) don't get translated. So they point to a non-existentREADME.html
path. mdBook should either generate bothindex.html
andREADME.html
or translate internal links so that they point toindex.html
instead.The text was updated successfully, but these errors were encountered: