Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link to c3 #418

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Fix broken link to c3 #418

merged 3 commits into from
Dec 16, 2021

Conversation

caemor
Copy link
Contributor

@caemor caemor commented Dec 15, 2021

Change absolute link to relative since the current link is broken since it starts from the root level which is one above where it should be with the new structure.

@caemor
Fix broken link to c3
a1518da 
Change absolute link to relative
@caemor caemor requested a review from a team as a code owner December 15, 2021 17:21
@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Dec 15, 2021
@adamgreig
Copy link
Member

Thanks! Weirdly the linkchecker didn't have a problem with it before, but now fails the CI with your correction. Maybe it's worth trying a relative URL without any preceding .. or /?

@caemor
Update debug-it.md
c1968da 
Try a / at the end
@caemor
Copy link
Contributor Author

caemor commented Dec 16, 2021

I tried to copy the behavior of https://github.com/rust-embedded/discovery/blob/master/microbit/src/05-led-roulette/debug-it.md?plain=1#L232 which is working.

In the CI the link-checker is currently run before the books are moved to their correct position and therefore the behavior might deviate from the expected behavior:

discovery/.github/workflows/ci.yml

Line 151 in 4b5e5c7

run: linkchecker book

I think I now found the issue that stopped this link from working: rust-lang/mdBook#984
Linking Readme.mds from other directories is broken. Workaround: Link to index.md which breaks the linkage outside of the website in your local folders when scrolling through the Markdownfiles

eldruin
eldruin approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work now, thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Dec 16, 2021

Build succeeded:

@bors bors bot merged commit 2669f78 into rust-embedded:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caemor @rust-highfive @adamgreig @eldruin