Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] links broken #497

Closed
lemmy opened this issue Jan 26, 2021 · 7 comments · Fixed by #499
Closed

[BUG] links broken #497

lemmy opened this issue Jan 26, 2021 · 7 comments · Fixed by #499
Assignees
Labels

Comments

@lemmy
Copy link
Contributor

lemmy commented Jan 26, 2021

Links at the bottom of e.g. https://github.com/informalsystems/apalache/tree/unstable/docs/src are broken.

@lemmy lemmy added the bug label Jan 26, 2021
@shonfeder
Copy link
Contributor

The markdown files are now used as the sources for the manual we build with mdBook: https://apalache.informal.systems/docs

As you can see, the links work in the manual.

Because of a shortcoming in mdBook (rust-lang/mdBook#984) we must choose between either letting the README.md files serve as landing pages when you open a directory in github or keeping links to README.md files working in both the raw markdown and the compiled end result. We have initially opted for the former, but maybe we should instead prefer the latter. We could preserve linking if we rename all README.md's in subdirs to index.md.

@konnov
Copy link
Collaborator

konnov commented Jan 26, 2021

@lemmy, how did you reach these links? Both github pages and the README.md are pointing to the docs at apalache.informal.systems.

@lemmy
Copy link
Contributor Author

lemmy commented Jan 26, 2021

My entry point was github.com/informalsystems/apalache. It's what I'm used to because of the issue tracker, commits, ...

@konnov
Copy link
Collaborator

konnov commented Jan 26, 2021

There was one broken link in README.md, addressed in #498. It is a good question what to do, if the reader navigates directly to docs.

@shonfeder
Copy link
Contributor

The readme of the docs directory currently makes it very clear that we compile the sources: https://github.com/informalsystems/apalache/tree/unstable/docs

I'll also add a link to compiled docs from there, and note that this is where one should go to read them.

My suggestion for linkability is that we rename all the README.md files to index.md files. This will work well for people who want to browse the source in their editors (me, for instance ;)), and will also work for people who want to use github interface,with the added bonus of making it clearer that that's not the recommended view port :)

@konnov
Copy link
Collaborator

konnov commented Jan 26, 2021

So index.md will not be rendered by default? That makes sense.

@shonfeder
Copy link
Contributor

shonfeder commented Jan 26, 2021

index.md will still be rendered, we just won't have README.mds in most directories of the docs, or if we do, they won't be part of the docs properly (as a rule) but will be actual readme's for looking at the source.

I think this is better practice really, the other way is just jumping through unnecessary hoops to accommodate github's UI choices, and it's not needed any longer now that we are building and serving the docs in a more usable form.

@shonfeder shonfeder self-assigned this Jan 26, 2021
@shonfeder shonfeder added this to the January iteration milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants