Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the the mdBook link preprocessor #499

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

shonfeder
Copy link
Contributor

Closes #497

Instead of having mdBook convert README.md files in the docs into index.md files, we just name the indexs properly. This keep linking consistent in both the markdown and rendered HTML, makes it easier to understand what's going on, and make sit clearer to someone looking at the docs via the github UI that it's not the convenient place to browse the documentation :)

I also link the manual from the README.md in the docs dir.

  • Tests added for any new code
  • Documentation added for any new functionality
  • Entry added to UNRELEASED.md for any new functionality

This removes some pointless magic from the mdBook compilation and makes
the links work consistently whether viewing the compiled book or the
markdown sources.
@shonfeder shonfeder requested a review from konnov January 26, 2021 16:45
Copy link
Collaborator

@konnov konnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shonfeder shonfeder merged commit 064c5dc into unstable Jan 26, 2021
@shonfeder shonfeder deleted the shon/fix-mdbook-linking branch January 26, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] links broken
2 participants