linting #64
Merged
linting #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plcplc
commented
Nov 14, 2023
specification/src/tutorial/schema.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Schema | |||
|
|
|||
| The [schema endpoint](../specification/schema/README.md) should return data describing the data connector's scalar and object types, along with any collections, functions and procedures which are exposed. | |||
| The [schema endpoint](../specification/schema/index.html) should return data describing the data connector's scalar and object types, along with any collections, functions and procedures which are exposed. | |||
There was a problem hiding this comment.
I'm not sure this is the right way to link in our markdown setup (i.e., it looks like it's confusing sources and compiled outputs, but the link that ended up in the compiled html still referenced a README.md, which is wrong)
There was a problem hiding this comment.
This looks like a known bug rust-lang/mdBook#984.
I don't think fixing it with a link to .html is really better, because it will break the link in the original markdown for anyone reading on GitHub (not recommended, but still).
There is a script in the issue to work around this, but I would say let's just remove this link for now.
paf31
reviewed
Nov 14, 2023
paf31
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing a few typos and dead links.