Allow tag query $*Class() methods to no-op on length 0 inputs
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Apr 22, 2021
cpsievert
approved these changes
Apr 22, 2021
schloerke
added a commit
that referenced
this pull request
Apr 22, 2021
* master: Allow tag query `$*Class()` methods to no-op on length 0 inputs (#236)
schloerke
added a commit
that referenced
this pull request
May 4, 2021
* master: `tagQuery()`: Rename`$root()` to `$allTags()`, `$selected()` to `$selectedTags()`; Print `$selectedTags()` like a `list()` (#230) tagQuery(): Rebuild less often and do not check for tag env cycles; Rename `$reset()` -> `$resetSelected()` (#235) Bump rlang dev version Revert "Return invisibly when not creating a new tagQuery() object (#228)" Allow tag query `$*Class()` methods to no-op on length 0 inputs (#236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216
Also works with
character(0)inputs (or any length 0 inputs)Moved the
$hasClass()method down so that the method order is "add, empty-like, has", similar to the attr method ontagQuery()