New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagQuery()'s $addClass() should allow NULL values #216

Closed

cpsievert opened this issue Apr 19, 2021 · 0 comments · Fixed by #236

Assignees

Collaborator

cpsievert commented Apr 19, 2021

Which would be a no-op and is convenient for this sort of use:

tagQuery(div())$addClass(if (F) "a")
#> Error in getCssClass(class) : 
#>  `class` must resolve to a character value with a length of at least 1

tagAppendChildren(div(), class = if (F) "a")
#> <div></div>

cpsievert assigned schloerke

schloerke mentioned this issue

Allow tag query $*Class() methods to no-op on length 0 inputs #236

Merged

schloerke closed this as completed in #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment