Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return invisibly when not creating a new tagQuery() object #228

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Return invisibly when not creating a new tagQuery() object #228

merged 1 commit into from
Apr 21, 2021

Conversation

schloerke
Copy link
Collaborator

Fixes #219

@schloerke schloerke requested a review from cpsievert April 21, 2021 17:26
@schloerke schloerke changed the title Return invisible(self) when not creating a new tagQuery() object Return invisibly when not creating a new tagQuery() object Apr 21, 2021
@schloerke schloerke merged commit 3a2757f into master Apr 21, 2021
@schloerke schloerke deleted the invis_return branch April 21, 2021 17:55
schloerke added a commit that referenced this pull request Apr 21, 2021
@schloerke
Merge branch 'master' into tag_render_fn
9f9ef63 
* master:
  Return invisibly when not creating a new tagQuery() object (#228)
schloerke added a commit that referenced this pull request Apr 22, 2021
@schloerke
Revert "Return invisibly when not creating a new tagQuery() object (#228
a909257 
)"

This reverts commit 3a2757f.
schloerke added a commit that referenced this pull request Apr 22, 2021
@schloerke
Revert "Return invisibly when not creating a new tagQuery() object (#228
62b2f7d 
)"

This reverts commit 3a2757f.
schloerke added a commit that referenced this pull request May 4, 2021
@schloerke
Merge branch 'master' into normalize_tag_attribs
f96b5c6 
* master:
  `tagQuery()`: Rename`$root()` to `$allTags()`, `$selected()` to `$selectedTags()`; Print `$selectedTags()` like a `list()` (#230)
  tagQuery(): Rebuild less often and do not check for tag env cycles; Rename `$reset()` -> `$resetSelected()` (#235)
  Bump rlang dev version
  Revert "Return invisibly when not creating a new tagQuery() object (#228)"
  Allow tag query `$*Class()` methods to no-op on length 0 inputs (#236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider having tagQuery()'s modifying methods return invisible()
2 participants
@schloerke @cpsievert