Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tagQuery(): Rebuild less often and do not check for tag env cycles; Rename $reset() -> $resetSelected() #235

Merged
merged 7 commits into from
May 3, 2021
Merged

tagQuery(): Rebuild less often and do not check for tag env cycles; Rename $reset() -> $resetSelected() #235

merged 7 commits into from
May 3, 2021

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Apr 22, 2021 •
edited
Loading

Fixes #237

  • Remove cycle checking as it is slow and a very rare situation
  • Do not rebuild unless it is possible something was altered. If the user needs to perform this themselves, they can call tagQuery(x)$rebuild()
  • Reduce work done when adding a pseudo root tag
  • Rename $reset() -> $resetSelected()

@schloerke schloerke changed the title tagQuery(): Do not rebuild or check for cycles tagQuery(): Do not rebuild or check for cycles; Rename $reset() -> $resetSelected() Apr 22, 2021
@schloerke schloerke mentioned this pull request Apr 22, 2021
Closed
@schloerke schloerke requested a review from cpsievert April 22, 2021 18:54
@schloerke schloerke marked this pull request as ready for review April 22, 2021 18:54
@cpsievert
Copy link
Collaborator

Seems good to me, but would be good if @wch has a look as well

@cpsievert cpsievert requested a review from wch April 22, 2021 19:19
@schloerke schloerke changed the title tagQuery(): Do not rebuild or check for cycles; Rename $reset() -> $resetSelected() tagQuery(): Rebuild less often and do not check for tag env cycles; Rename $reset() -> $resetSelected() Apr 22, 2021
@cpsievert cpsievert merged commit 50fe7a2 into master May 3, 2021
@cpsievert cpsievert deleted the build_less_often branch May 3, 2021 20:28
@cpsievert cpsievert mentioned this pull request May 3, 2021
Merged
schloerke added a commit that referenced this pull request May 4, 2021
@schloerke
Merge branch 'master' into normalize_tag_attribs
f96b5c6 
* master:
  `tagQuery()`: Rename`$root()` to `$allTags()`, `$selected()` to `$selectedTags()`; Print `$selectedTags()` like a `list()` (#230)
  tagQuery(): Rebuild less often and do not check for tag env cycles; Rename `$reset()` -> `$resetSelected()` (#235)
  Bump rlang dev version
  Revert "Return invisibly when not creating a new tagQuery() object (#228)"
  Allow tag query `$*Class()` methods to no-op on length 0 inputs (#236)
@schloerke schloerke mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

@wch wch Awaiting requested review from wch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sibling modifier methods appear to have some issues
2 participants
@schloerke @cpsievert