-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libgmock-dev to Buster & Focal. #27195
Conversation
`google-mock` is a transitional package and shouldn't be used anymore. See https://packages.debian.org/buster/google-mock
Would it also be supported to use a rule like |
It might work if it was tried but as far as I know only by accident and I do not think we want to encourage the use of complex dependency logic within rosdep itself as not every target system has the same mechanisms for expressing that logic. My initial feeling is that it makes more sense to add a new key for libgmock-dev so that projects can switch to rather than trying to affect our own transition within the old package name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think creating a new key for the new package name and making sure that we provide a null definition for this transitional package key when it is no longer available.
@MichaelGrupp Friendly ping |
Sorry for the delay. I addressed your comments, I'm not completely sure if I did it correct tbh. Please have a look. |
If the plan is to recommend people move away from the Lines 1185 to 1193 in 85888e1
@ros/rosdeputies Thoughts on what keys are correct for freebsd, openembedded, opensuse, and rhel? |
Yes if libgmock-dev is the new recommended one we should make sure to fill it in on all platforms so people can transition. |
@MichaelGrupp Friendly ping. Are you able to fill in the requested platforms described above (#27195 (comment))? Thanks! |
@jacobperron Done. Sorry for the late reply, just came back from vacation. |
* rviz_satellite: 3.0.3-1 in 'melodic/distribution.yaml' [bloom] (ros#28039) * update branch name for moveit_python (melodic) (ros#28026) * rviz_satellite: 3.0.3-1 in 'melodic/distribution.yaml' [bloom] (ros#28039) * ros2-lgsvl-bridge: 0.3.0-1 in 'dashing/distribution.yaml' [bloom] (ros#28037) * rc_genicam_driver: 0.1.1-1 in 'foxy/distribution.yaml' [bloom] (ros#28035) * moveit_python: 0.4.0-1 in 'noetic/distribution.yaml' [bloom] (ros#28033) * cnpy: 0.0.6-1 in 'noetic/distribution.yaml' [bloom] (ros#28032) Co-authored-by: Peter Mitrano <pmitrano@armstorm> * octomap_rviz_plugins: 0.2.3-1 in 'noetic/distribution.yaml' [bloom] (ros#28031) * cob_android: 0.1.9-1 in 'noetic/distribution.yaml' [bloom] (ros#28030) * cob_android: 0.1.9-1 in 'kinetic/distribution.yaml' [bloom] (ros#28029) * nmea_navsat_driver: 0.6.1-2 in 'noetic/distribution.yaml' [bloom] (ros#28028) * update branch name for moveit_python (noetic) (ros#28027) * update branch name for moveit_python (kinetic) (ros#28025) * fkie_multimaster: 1.2.6-2 in 'noetic/distribution.yaml' [bloom] (ros#28024) * ueye_cam: 1.0.19-1 in 'noetic/distribution.yaml' [bloom] (ros#28023) * rc_reason_clients: 0.2.1-1 in 'dashing/distribution.yaml' [bloom] (ros#28022) * New verbiage designating the release manager as the authority for maintainership changes (ros#28000) * New verbiage designating the release manager as the authority for * Update REVIEW_GUIDELINES.md Co-authored-by: Jacob Perron <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Jacob Perron <[email protected]> * dgps_ros: 1.0.0-4 in 'kinetic/distribution.yaml' (ros#27969) * dgps_ros: 1.0.0-4 in 'kinetic/distribution.yaml' increasing version of dgps_ros to 1.0.0-4, to fix the building problem * Rosdep rule for python3-sympy (ros#27881) * Rosdep rule for python3-sympy Co-authored-by: Shane Loretz <[email protected]> * rviz_satellite: 3.0.3-1 in 'noetic/distribution.yaml' [bloom] (ros#28043) * vrpn_client_ros: 0.2.2-1 in 'noetic/distribution.yaml' [bloom] (ros#28042) * rc_reason_clients: 0.2.1-1 in 'foxy/distribution.yaml' [bloom] (ros#28040) * Add libgmock-dev to Buster & Focal. (ros#27195) * Add moving_average (ros#28038) * map_transformer: 1.0.0-1 in 'foxy/distribution.yaml' [bloom] (ros#28013) * map_transformer: 1.0.0-1 in 'foxy/distribution.yaml' [bloom] * Add python3-cffi rosdep key (ros#27930) * Add python3-cffi rosdep key Signed-off-by: Shane Loretz <[email protected]> * Add rhel Signed-off-by: Shane Loretz <[email protected]> Co-authored-by: Scott K Logan <[email protected]> Co-authored-by: Scott K Logan <[email protected]> * Add castxml (ros#27964) * rosdep: add ansible-runner as python-ansible-runner-pip (ros#27976) * rosdep: add ansible-runner as python-ansible-runner-pip * use python3- prefix * async_web_server_cpp: 2.0.0-1 in 'rolling/distribution.yaml' [bloom] (ros#27997) * [rosdep] python3-dbus (ros#28034) * [rosdep] python3-watchdog, python3-tabulate, python3-jsonschema, python3-flask (ros#28036) These rosdep keys already existed for Python 2; this adds Python 3 versions of them. Watchdog: - Debian: https://packages.debian.org/buster/python3-watchdog - Fedora: https://fedora.pkgs.org/33/fedora-x86_64/python3-watchdog-0.10.2-3.fc33.noarch.rpm.html - Gentoo: https://packages.gentoo.org/packages/dev-python/watchdog - Ubuntu: https://packages.ubuntu.com/focal/python3-watchdog Tabulate: - Debian: https://packages.debian.org/buster/python3-tabulate - Fedora: https://fedora.pkgs.org/33/fedora-x86_64/python3-tabulate-0.8.7-4.fc33.noarch.rpm.html - Gentoo: https://packages.gentoo.org/packages/dev-python/tabulate - Ubuntu: https://packages.ubuntu.com/focal/python3-tabulate Jsonschema: - Debian: https://packages.debian.org/buster/python3-jsonschema - Fedora: https://fedora.pkgs.org/33/fedora-x86_64/python3-jsonschema-3.2.0-7.fc33.noarch.rpm.html - Gentoo: https://packages.gentoo.org/packages/dev-python/jsonschema - Ubuntu: https://packages.ubuntu.com/focal/python3-jsonschema Flask: - Debian: https://packages.debian.org/buster/python3-flask - Fedora: https://fedora.pkgs.org/33/fedora-x86_64/python3-flask-1.1.2-4.fc33.noarch.rpm.html - Gentoo: https://packages.gentoo.org/packages/dev-python/flask - Ubuntu: https://packages.ubuntu.com/focal/python3-flask * [rosdep] file (ros#27984) * libmpg123-dev (ros#27970) * Add pathlib2 to python yaml (ros#27782) * Add pathlib2 to python yaml * ros_controllers: 0.17.2-1 in 'melodic/distribution.yaml' [bloom] (ros#28044) * rclc: 0.1.7-1 in 'foxy/distribution.yaml' [bloom] (ros#28047) * rclc: 0.1.7-1 in 'dashing/distribution.yaml' [bloom] (ros#28046) * rclc: 0.1.7-1 in 'rolling/distribution.yaml' [bloom] (ros#28048) * async_comm: 0.2.1-3 in 'kinetic/distribution.yaml' [bloom] (ros#28050) * ros2_control: 0.1.3-1 in 'foxy/distribution.yaml' [bloom] (ros#28054) * async_comm: 0.2.1-1 in 'melodic/distribution.yaml' [bloom] (ros#28051) * map_transformer: 1.0.0-4 in 'foxy/distribution.yaml' [bloom] (ros#28055) * Revert "ueye_cam: 1.0.18-1 in 'melodic/distribution.yaml' [bloom] (ros#27934)" (ros#28059) This reverts commit a8a6d5c. * Revert "async_comm: 0.2.1-1 in 'melodic/distribution.yaml' [bloom] (ros#28051)" (ros#28061) This reverts commit 5c9dc11. * control_msgs: 2.5.0-1 in 'foxy/distribution.yaml' [bloom] (ros#28060) * update rosdep python-construct (ros#28056) Co-authored-by: Scott K Logan <[email protected]> * rosdep: add python3-bitarray (ros#28053) * async_comm: 0.2.1-1 in 'noetic/distribution.yaml' [bloom] (ros#28052) * nmea_comms: 1.2.0-3 in 'noetic/distribution.yaml' [bloom] (ros#28062) * control_msgs: 2.5.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28064) * fkie_multimaster: 1.2.7-1 in 'noetic/distribution.yaml' [bloom] (ros#28066) * octomap: 1.9.6-1 in 'noetic/distribution.yaml' [bloom] (ros#28068) * lms1xx: 0.3.0-2 in 'noetic/distribution.yaml' [bloom] (ros#28070) * add gpp-package (ros#27973) * add gpp-package * add doc section * robot_state_publisher: 2.4.2-1 in 'foxy/distribution.yaml' [bloom] (ros#28084) * cartographer_ros: 1.0.9003-1 in 'foxy/distribution.yaml' [bloom] (ros#28100) * ament_cmake_ros: 0.9.1-1 in 'foxy/distribution.yaml' [bloom] (ros#28103) * ament_index: 1.0.2-1 in 'foxy/distribution.yaml' [bloom] (ros#28106) * cartographer_ros: 1.0.9003-1 in 'dashing/distribution.yaml' [bloom] (ros#28101) * orocos_kinematics_dynamics: 3.3.2-1 in 'foxy/distribution.yaml' [bloom] (ros#28113) * libyaml_vendor: 1.0.3-1 in 'foxy/distribution.yaml' [bloom] (ros#28111) * ros1_bridge: 0.10.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28120) * rclcpp: 6.3.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28119) * ros2cli: 0.11.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28118) * rmw_fastrtps: 4.3.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28117) * rmw_implementation: 2.1.1-2 in 'rolling/distribution.yaml' [bloom] (ros#28116) * rmw_connext: 3.5.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28115) * rclpy: 1.5.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28114) * orocos_kinematics_dynamics: 3.3.2-1 in 'rolling/distribution.yaml' [bloom] (ros#28112) * libyaml_vendor: 1.1.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28110) * common_interfaces: 2.2.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28109) * uncrustify_vendor: 1.5.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28108) * mimick_vendor: 0.2.4-1 in 'rolling/distribution.yaml' [bloom] (ros#28107) * ament_index: 1.0.2-1 in 'rolling/distribution.yaml' [bloom] (ros#28105) * geometry2: 0.16.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28104) * ament_cmake_ros: 0.9.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28102) * cartographer_ros: 1.0.9003-1 in 'rolling/distribution.yaml' [bloom] (ros#28099) * launch: 0.15.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28098) * examples: 0.10.2-1 in 'rolling/distribution.yaml' [bloom] (ros#28097) * demos: 0.12.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28096) * rcl_logging: 2.1.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28095) * rcl: 2.5.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28094) * rcpputils: 2.0.4-1 in 'rolling/distribution.yaml' [bloom] (ros#28093) * launch_ros: 0.13.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28092) * rcutils: 3.1.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28091) * rosidl: 2.0.3-1 in 'rolling/distribution.yaml' [bloom] (ros#28089) * rosidl_typesupport: 1.1.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28088) * rviz: 8.3.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28087) * spdlog_vendor: 1.2.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28086) * python_qt_binding: 1.0.6-1 in 'rolling/distribution.yaml' [bloom] (ros#28085) * robot_state_publisher: 2.4.2-1 in 'rolling/distribution.yaml' [bloom] (ros#28083) * pluginlib: 5.0.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28082) * rmw_cyclonedds: 0.18.4-1 in 'rolling/distribution.yaml' [bloom] (ros#28081) * osrf_pycommon: 0.2.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28080) * googletest: 1.10.9001-1 in 'rolling/distribution.yaml' [bloom] (ros#28079) * ament_package: 0.10.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28078) * ament_lint: 0.10.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28077) * rmw: 3.0.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28076) * ament_cmake: 1.0.4-1 in 'rolling/distribution.yaml' [bloom] (ros#28075) * map_transformer: 1.0.1-1 in 'foxy/distribution.yaml' [bloom] (ros#28122) * add embree to rosdep (ros#28065) Signed-off-by: Masaya Kataoka <[email protected]> * nodelet_core: 1.10.1-1 in 'noetic/distribution.yaml' [bloom] (ros#28121) * pinocchio: 2.5.6-1 in 'noetic/distribution.yaml' [bloom] (ros#28074) * eigenpy: 2.6.1-1 in 'noetic/distribution.yaml' [bloom] (ros#28073) * cob_command_tools: 0.6.20-1 in 'noetic/distribution.yaml' [bloom] (ros#28071) * cob_command_tools: 0.6.20-1 in 'kinetic/distribution.yaml' [bloom] (ros#28072) * Adding twist_stamper to src/doc index for foxy & rolling (ros#28063) * Added teleop_legged_robots for noetic (ros#28021) Added teleop_legged_robots for noetic * Update distribution.yaml (ros#28020) * Adding new repositories for indexing (ros#28058) * Adding new repository for indexing: leica_point_cloud_processing * Adding new repository for indexing: leica_gazebo_simulation * Adding new repository for indexing: leica_scanstation * Add teleop_legged_robots for melodic (ros#28019) * Update distribution.yaml Added teleop_legged_robots package * added source and doc * rx_service_tools: 1.0.1-1 in 'melodic/distribution.yaml' [bloom] (ros#27983) * cyclonedds: 0.7.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28123) * laser_proc: 1.0.2-3 in 'rolling/distribution.yaml' [bloom] (ros#28127) * laser_proc: 1.0.2-1 in 'foxy/distribution.yaml' [bloom] (ros#28128) * laser_proc: 1.0.2-1 in 'dashing/distribution.yaml' [bloom] (ros#28129) * Switch source and doc branch of Rolling qt_gui_core to galactic-devel (ros#28132) Signed-off-by: Chris Lalancette <[email protected]> * bond_core: 3.0.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28133) * bond_core: 3.0.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28134) * qt_gui_core: 2.0.0-1 in 'rolling/distribution.yaml' [bloom] (ros#28135) * eigenpy: 2.6.1-3 in 'noetic/distribution.yaml' [bloom] (ros#28136) * map_transformer: 1.0.2-1 in 'foxy/distribution.yaml' [bloom] (ros#28137) * interactive_marker_twist_server: 1.2.1-1 in 'noetic/distribution.yaml' [bloom] (ros#28131) * interactive_marker_twist_server: 1.2.1-1 in 'melodic/distribution.yaml' [bloom] (ros#28130) * Update distribution.yaml (ros#28126) * Update distribution.yaml (ros#28125) * map_transformer: 1.0.3-1 in 'foxy/distribution.yaml' [bloom] (ros#28140) * behaviortree_cpp: 3.5.5-1 in 'foxy/distribution.yaml' [bloom] (ros#28146) Co-authored-by: Davide Faconti <[email protected]> * plotjuggler_ros: 1.0.3-8 in 'foxy/distribution.yaml' [bloom] (ros#28143) Co-authored-by: Davide Faconti <[email protected]> * khi_robot: 1.2.0-5 in 'kinetic/distribution.yaml' [bloom] (ros#28138) * behaviortree_cpp: 3.5.5-2 in 'noetic/distribution.yaml' [bloom] (ros#28145) Co-authored-by: Davide Faconti <[email protected]> * rc_genicam_driver: 0.5.0-1 in 'kinetic/distribution.yaml' [bloom] (ros#28149) * rc_genicam_driver: 0.5.0-1 in 'melodic/distribution.yaml' [bloom] (ros#28150) * rc_genicam_driver: 0.5.0-1 in 'noetic/distribution.yaml' [bloom] (ros#28151) * behaviotree_cpp_v3: 3.5.5-2 in 'melodic/distribution.yaml' [bloom] (ros#28144) Co-authored-by: Davide Faconti <[email protected]> * Change Heifu branch for documentation and source (ros#28124) * Change Heifu branch for documentation and source. Co-authored-by: André <[email protected]> Co-authored-by: amferreiraBEV <[email protected]> Co-authored-by: André Filipe <[email protected]> * neonavigation: 0.10.6-1 in 'melodic/distribution.yaml' [bloom] (ros#28157) * neonavigation: 0.10.6-1 in 'kinetic/distribution.yaml' [bloom] (ros#28156) * nonpersistent_voxel_layer: 1.3.0-2 in 'noetic/distribution.yaml' [bloom] (ros#28159) * Update default branch for transport_drivers (ros#28154) * khi_robot: 1.2.0-1 in 'melodic/distribution.yaml' [bloom] (ros#28139) * neonavigation: 0.10.6-1 in 'noetic/distribution.yaml' [bloom] (ros#28158) * update branch for rolling PR job (ros#28161) * rx_service_tools: 1.0.2-1 in 'noetic/distribution.yaml' [bloom] (ros#28142) * diagnostics: 2.0.6-1 in 'foxy/distribution.yaml' [bloom] (ros#28162) * diagnostics: 2.1.1-1 in 'rolling/distribution.yaml' [bloom] (ros#28163) * rc_genicam_camera: 1.2.3-1 in 'noetic/distribution.yaml' [bloom] (ros#28153) * Add RHEL rules for java and maven (ros#28045) * Add RHEL 7 rule for sdformat (ros#28049) * [rosdep] python3-numpy-stl (ros#27986) * [rosdep] python3-numpy-stl Co-authored-by: Steven! Ragnarök <[email protected]> Co-authored-by: Ivan Santiago Paunovic <[email protected]> Co-authored-by: Tim Clephas <[email protected]> Co-authored-by: Michael Ferguson <[email protected]> Co-authored-by: Hadi Tabatabaee <[email protected]> Co-authored-by: Felix Ruess <[email protected]> Co-authored-by: Peter Mitrano <[email protected]> Co-authored-by: Peter Mitrano <pmitrano@armstorm> Co-authored-by: Wolfgang Merkt <[email protected]> Co-authored-by: Felix Messmer <[email protected]> Co-authored-by: Ed Venator <[email protected]> Co-authored-by: Alexander Tiderko <[email protected]> Co-authored-by: Anqi Xu <[email protected]> Co-authored-by: Tully Foote <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> Co-authored-by: Jacob Perron <[email protected]> Co-authored-by: qinyunchuan <[email protected]> Co-authored-by: Jonathan Binney <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Paul Bovbel <[email protected]> Co-authored-by: Michael Grupp <[email protected]> Co-authored-by: Victor Lamoine <[email protected]> Co-authored-by: Geoffrey Biggs <[email protected]> Co-authored-by: Shane Loretz <[email protected]> Co-authored-by: Scott K Logan <[email protected]> Co-authored-by: Matthijs van der Burgh <[email protected]> Co-authored-by: hocjordan <[email protected]> Co-authored-by: Timo Röhling <[email protected]> Co-authored-by: Rein Appeldoorn <[email protected]> Co-authored-by: P. J. Reed <[email protected]> Co-authored-by: Tony Yu Cao <[email protected]> Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Jan Staschulat <[email protected]> Co-authored-by: Daniel Koch <[email protected]> Co-authored-by: Matthias Gruhler <[email protected]> Co-authored-by: Tony Baltovski <[email protected]> Co-authored-by: Dima Dorezyuk <[email protected]> Co-authored-by: Masaya Kataoka <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Josh Newans <[email protected]> Co-authored-by: tarasborov <[email protected]> Co-authored-by: Ines Lara Sicilia <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: Davide Faconti <[email protected]> Co-authored-by: Davide Faconti <[email protected]> Co-authored-by: Daisuke NAKAMICHI <[email protected]> Co-authored-by: BV-OpenSource <[email protected]> Co-authored-by: André <[email protected]> Co-authored-by: amferreiraBEV <[email protected]> Co-authored-by: André Filipe <[email protected]> Co-authored-by: Atsushi Watanabe <[email protected]> Co-authored-by: Steve Macenski <[email protected]> Co-authored-by: Joshua Whitley <[email protected]> Co-authored-by: Karsten Knese <[email protected]>
google-mock
is a transitional package and shouldn't be used anymore.See https://packages.debian.org/buster/google-mock