Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused velocity scaling config from example xml #3330

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Remove unused velocity scaling config from example xml #3330

merged 1 commit into from
Dec 18, 2022

Conversation

borongyuan
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo Simulation of TurtleBot3

Description of contribution in a few bullet points

Minor addition to (#2701) and (#3047)

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Dec 18, 2022

@borongyuan, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit c629474 into ros-navigation:main Dec 18, 2022
SteveMacenski pushed a commit that referenced this pull request Dec 21, 2022
@borongyuan @SteveMacenski
Remove unused velocity scaling config from example xml (#3330)
37c7700 
Signed-off-by: Borong Yuan <[email protected]>

Signed-off-by: Borong Yuan <[email protected]>
SteveMacenski added a commit that referenced this pull request Dec 21, 2022
@SteveMacenski @Aposhian
@guilyx @svenlr @borongyuan @AlexeyMerzlyakov @MartiBolet @owen7900 @pepisg
Humble sync 3: Dec 20 (#3334)
ed7f5ef 
* remove exec_depend on behaviortree_cpp_v3 (#3279)

* BT Service Node to throw if service was not available in time (#3256)

* throw if service server wasn't available in time

mimic the behavior of the bt action node constructor

* throw if action unavailable in bt cancel action

* use chrono literals namespace

* fix linting errors

* fix code style divergence

* Remove duplicate of nav2_back_up_cancel_bt_node (#3332)

* Remove unused velocity scaling config from example xml (#3330)

Signed-off-by: Borong Yuan <[email protected]>

Signed-off-by: Borong Yuan <[email protected]>

* Make mapUpdateLoop() indicator variables to be thread-safe (#3308)

* Ensure that plugin initialization to be called before updating routines (#3307)

* Solve bug when CostmapInfoServer is reactivated (#3292)

* Solve bug when CostmapInfoServer is reactivated

* Implemented smoother selector bt node (#3283)

* Implemented smoother selector bt node

Signed-off-by: Owen Hooper <[email protected]>

* updated copyright in modified file

Signed-off-by: Owen Hooper <[email protected]>

Signed-off-by: Owen Hooper <[email protected]>

* Add allow_unknown parameter to theta star planner (#3286)

* Add allow unknown parameter to theta star planner

* Add allow unknown parameter to tests

* missing comma

* Change cost of unknown tiles

* Uncrustify

* bump to 1.1.3 for humble sync 3

Signed-off-by: Borong Yuan <[email protected]>
Signed-off-by: Owen Hooper <[email protected]>
Co-authored-by: Adam Aposhian <[email protected]>
Co-authored-by: Erwin Lejeune <[email protected]>
Co-authored-by: Sven Langner <[email protected]>
Co-authored-by: Borong Yuan <[email protected]>
Co-authored-by: Alexey Merzlyakov <[email protected]>
Co-authored-by: MartiBolet <[email protected]>
Co-authored-by: Owen Hooper <[email protected]>
Co-authored-by: Pedro Alejandro González <[email protected]>
andrewlycas pushed a commit to StratomInc/navigation2 that referenced this pull request Feb 23, 2023
@borongyuan
Remove unused velocity scaling config from example xml (ros-navigatio…
5110b6e 
…n#3330)

Signed-off-by: Borong Yuan <[email protected]>

Signed-off-by: Borong Yuan <[email protected]>
shrijitsingh99 pushed a commit to moss-ag/navigation2 that referenced this pull request Mar 4, 2023
@SteveMacenski @Aposhian
@guilyx @svenlr @borongyuan @AlexeyMerzlyakov @MartiBolet @owen7900 @pepisg @shrijitsingh99
Humble sync 3: Dec 20 (ros-navigation#3334)
c994c50 
* remove exec_depend on behaviortree_cpp_v3 (ros-navigation#3279)

* BT Service Node to throw if service was not available in time (ros-navigation#3256)

* throw if service server wasn't available in time

mimic the behavior of the bt action node constructor

* throw if action unavailable in bt cancel action

* use chrono literals namespace

* fix linting errors

* fix code style divergence

* Remove duplicate of nav2_back_up_cancel_bt_node (ros-navigation#3332)

* Remove unused velocity scaling config from example xml (ros-navigation#3330)

Signed-off-by: Borong Yuan <[email protected]>

Signed-off-by: Borong Yuan <[email protected]>

* Make mapUpdateLoop() indicator variables to be thread-safe (ros-navigation#3308)

* Ensure that plugin initialization to be called before updating routines (ros-navigation#3307)

* Solve bug when CostmapInfoServer is reactivated (ros-navigation#3292)

* Solve bug when CostmapInfoServer is reactivated

* Implemented smoother selector bt node (ros-navigation#3283)

* Implemented smoother selector bt node

Signed-off-by: Owen Hooper <[email protected]>

* updated copyright in modified file

Signed-off-by: Owen Hooper <[email protected]>

Signed-off-by: Owen Hooper <[email protected]>

* Add allow_unknown parameter to theta star planner (ros-navigation#3286)

* Add allow unknown parameter to theta star planner

* Add allow unknown parameter to tests

* missing comma

* Change cost of unknown tiles

* Uncrustify

* bump to 1.1.3 for humble sync 3

Signed-off-by: Borong Yuan <[email protected]>
Signed-off-by: Owen Hooper <[email protected]>
Co-authored-by: Adam Aposhian <[email protected]>
Co-authored-by: Erwin Lejeune <[email protected]>
Co-authored-by: Sven Langner <[email protected]>
Co-authored-by: Borong Yuan <[email protected]>
Co-authored-by: Alexey Merzlyakov <[email protected]>
Co-authored-by: MartiBolet <[email protected]>
Co-authored-by: Owen Hooper <[email protected]>
Co-authored-by: Pedro Alejandro González <[email protected]>
shrijitsingh99 pushed a commit to moss-ag/navigation2 that referenced this pull request Mar 4, 2023
@SteveMacenski @Aposhian
@guilyx @svenlr @borongyuan @AlexeyMerzlyakov @MartiBolet @owen7900 @pepisg @shrijitsingh99
Humble sync 3: Dec 20 (ros-navigation#3334)
c370103 
* remove exec_depend on behaviortree_cpp_v3 (ros-navigation#3279)

* BT Service Node to throw if service was not available in time (ros-navigation#3256)

* throw if service server wasn't available in time

mimic the behavior of the bt action node constructor

* throw if action unavailable in bt cancel action

* use chrono literals namespace

* fix linting errors

* fix code style divergence

* Remove duplicate of nav2_back_up_cancel_bt_node (ros-navigation#3332)

* Remove unused velocity scaling config from example xml (ros-navigation#3330)

Signed-off-by: Borong Yuan <[email protected]>

Signed-off-by: Borong Yuan <[email protected]>

* Make mapUpdateLoop() indicator variables to be thread-safe (ros-navigation#3308)

* Ensure that plugin initialization to be called before updating routines (ros-navigation#3307)

* Solve bug when CostmapInfoServer is reactivated (ros-navigation#3292)

* Solve bug when CostmapInfoServer is reactivated

* Implemented smoother selector bt node (ros-navigation#3283)

* Implemented smoother selector bt node

Signed-off-by: Owen Hooper <[email protected]>

* updated copyright in modified file

Signed-off-by: Owen Hooper <[email protected]>

Signed-off-by: Owen Hooper <[email protected]>

* Add allow_unknown parameter to theta star planner (ros-navigation#3286)

* Add allow unknown parameter to theta star planner

* Add allow unknown parameter to tests

* missing comma

* Change cost of unknown tiles

* Uncrustify

* bump to 1.1.3 for humble sync 3

Signed-off-by: Borong Yuan <[email protected]>
Signed-off-by: Owen Hooper <[email protected]>
Co-authored-by: Adam Aposhian <[email protected]>
Co-authored-by: Erwin Lejeune <[email protected]>
Co-authored-by: Sven Langner <[email protected]>
Co-authored-by: Borong Yuan <[email protected]>
Co-authored-by: Alexey Merzlyakov <[email protected]>
Co-authored-by: MartiBolet <[email protected]>
Co-authored-by: Owen Hooper <[email protected]>
Co-authored-by: Pedro Alejandro González <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borongyuan @SteveMacenski